Fix/nlte ionization matrix #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christian Vogl <cvogl@mpa-garching.mpg.de>
Co-authored-by: Christian Vogl <cvogl@mpa-garching.mpg.de>
Co-authored-by: Christian Vogl <cvogl@mpa-garching.mpg.de>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
87 changed files? |
yes - this depends on #2500. It's otherwise difficult to work with. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2501 +/- ##
==========================================
+ Coverage 68.13% 68.67% +0.53%
==========================================
Files 166 165 -1
Lines 13961 13988 +27
==========================================
+ Hits 9513 9606 +93
+ Misses 4448 4382 -66 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The negative value problem seems to have been caused by a greater sign error in the negative value fixer module
REQUIRES THE merge of #2500