Restructure/estimators #2500
Closed
Restructure/estimators #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christian Vogl <cvogl@mpa-garching.mpg.de>
| @@ -44,4 +46,6 @@ def calculate_mean_intensity(self, nu): | |||
| intensity : u.Quantity | |||
| Intensity of the radiation field at the given frequency | |||
| """ | |||
| return self.dilution_factor * intensity_black_body(nu, self.t_radiative) | |||
| return self.dilution_factor * intensity_black_body( | |||
| nu[np.newaxis].T, self.t_radiative | |||
There was a problem hiding this comment.
Why is this transpose happening here?
There was a problem hiding this comment.
this is the number of nues vs the number of shells - what comes out is a 2D frame
| 2D array with integrated values. | ||
| """ | ||
| integrated = np.zeros((len(block_references) - 1, f.shape[1])) | ||
| for i in prange(f.shape[1]): # columns |
There was a problem hiding this comment.
This doesn't respect the nthreads setting!
Only causes issues if JIT is disabled, but this is more consistent anyway.
This was referenced Feb 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at restructuring the estimator code.
requires #2492 to be merged.