Initial commit for ctrl&data preloading. #69

yyan7223 · 2025-01-19T14:30:44Z

No description provided.

yyan7223 · 2025-01-19T14:38:46Z

I'm confused about how to transmit preload data through NoC.
should it be:
recv_from_noc->recv_from_tile_store_request_pkt_queue->crossbar->send_to_noc ?
if belongs to current controller, then recv_from_noc->send_to_tile_store_request_data_queue ?

yyan7223 · 2025-01-19T14:44:05Z

Another issue is that CtrlPktType of recv_ctrl_pkt_queue is incompatible with NocPktType of recv_from_noc
The former has many fields like ctrl_addr, ctrl_operation, ctrl_fu_in, while the latter only has addr and data
which means the recv_from_cpu_ctrl_pkt of the first controller cannot be transferred to other controllers through NoC.

tancheng · 2025-01-19T18:27:42Z

Another issue is that CtrlPktType of recv_ctrl_pkt_queue is incompatible with NocPktType of recv_from_noc The former has many fields like ctrl_addr, ctrl_operation, ctrl_fu_in, while the latter only has addr and data which means the recv_from_cpu_ctrl_pkt of the first controller cannot be transferred to other controllers through NoC.

Replied here: #68 (comment)

tancheng · 2025-01-19T18:47:56Z

I'm confused about how to transmit preload data through NoC. should it be: recv_from_noc->recv_from_tile_store_request_pkt_queue->crossbar->send_to_noc ? if belongs to current controller, then recv_from_noc->send_to_tile_store_request_data_queue ?

We just need to send data pkt into NoC regardless the pkt's dst (via the s.crossbar.recv[kStoreRequestInportIdx] or a new crossbar recv port). So all the pkts would go into NoC first. Then, I believe following can already automatically handle current controller case:

VectorCGRA/controller/ControllerRTL.py

Line 230 in 7222dae

elif s.recv_from_noc.msg.cmd == CMD_STORE_REQUEST:

Each controller would only receive the pkt belonging to its self, i.e., controller 2 would never receive pkt belonging to controller 1/3.

tancheng · 2025-01-19T18:50:54Z

controller/ControllerRTL.py

+    @update
+    def update_send_to_ctrl_ring_msg():
+      # Delivers the ctrl pkt that belongs to current controller to the CGRA tiles.
+      if s.recv_ctrl_pkt_queue.send.msg.dst == controller_id:
+        if s.send_to_ctrl_ring_ctrl_pkt.rdy:
+          s.send_to_ctrl_ring_ctrl_pkt.val @= 1
+          s.send_to_ctrl_ring_ctrl_pkt.msg @= s.recv_ctrl_pkt_queue.send.msg
+      else:
+          s.send_to_ctrl_ring_ctrl_pkt.val @= 0
+          s.send_to_ctrl_ring_ctrl_pkt.msg @= CtrlPktType()
+


You already send config into NoC. Then the handler should be implemented on line 275.

tancheng · 2025-01-19T18:52:05Z

lib/cmd_type.py

@@ -19,6 +19,8 @@
 CMD_LOAD_REQUEST  = 4
 CMD_LOAD_RESPONSE = 5
 CMD_STORE_REQUEST = 6
+CMD_PRELOAD_CTRL  = 7


CMD_CONFIG if for this purpose.

tancheng · 2025-01-19T18:52:26Z

lib/cmd_type.py

@@ -19,6 +19,8 @@
 CMD_LOAD_REQUEST  = 4
 CMD_LOAD_RESPONSE = 5
 CMD_STORE_REQUEST = 6
+CMD_PRELOAD_CTRL  = 7
+CMD_PRELOAD_DATA  = 8


CMD_STORE_REQUEST can be leveraged for this purpose.

tancheng · 2025-01-19T18:54:03Z

controller/ControllerRTL.py

+      if controller_id == 0:
+        # Preloads ctrl to the 1st controller.
+        if s.recv_ctrl_pkt_queue.recv.rdy:
+          s.recv_ctrl_pkt_queue.recv.val @= s.recv_from_cpu_ctrl_pkt.val
+          s.recv_ctrl_pkt_queue.recv.msg @= s.recv_from_cpu_ctrl_pkt.msg
+        # Preloads data to the 1st controller.
+        if s.send_to_tile_store_request_addr_queue.recv.rdy & \
+          s.send_to_tile_store_request_data_queue.recv.rdy:
+          s.recv_from_cpu_ctrl_pkt.rdy @= 1
+          # TODO: Renames recv_from_cpu_ctrl_pkt to recv_from_cpu_pkt, add cmd, data, and addr field for preloading.
+          #s.send_to_tile_store_request_addr_queue.recv.msg @= \
+          #      CGRAAddrType(s.recv_from_cpu_ctrl_pkt.msg.addr)
+          #s.send_to_tile_store_request_data_queue.recv.msg @= \
+          #      CGRADataType(s.recv_from_cpu_ctrl_pkt.msg.data, s.recv_from_cpu_ctrl_pkt.msg.predicate, 0, 0)
+          s.send_to_tile_store_request_addr_queue.recv.msg @= CGRAAddrType()
+          s.send_to_tile_store_request_data_queue.recv.msg @= CGRADataType()
+          s.send_to_tile_store_request_addr_queue.recv.val @= s.recv_from_cpu_ctrl_pkt.val
+          s.send_to_tile_store_request_data_queue.recv.val @= s.recv_from_cpu_ctrl_pkt.val
+
+      else:
+        # Preloads ctrl to the rest of controllers through NoC.
+        if s.recv_from_noc.msg.cmd == CMD_PRELOAD_CTRL:
+          if s.recv_ctrl_pkt_queue.recv.rdy:
+            s.recv_ctrl_pkt_queue.recv.val @= s.recv_from_noc.val
+            # TODO: CtrlPktType of recv_ctrl_pkt_queue is incompatible with NocPktType of recv_from_noc.
+            #s.recv_ctrl_pkt_queue.recv.msg @= CtrlPktType(received_pkt.src,
+            #                                                  received_pkt.dst,
+            #                                                  received_pkt.opaque,
+            #                                                  received_pkt.cmd,
+            #                                                  received_pkt.addr,
+            #                                                  received_pkt.data,
+            #                                                  received_pkt.predicate)
+        # Preloads data to the rest of controllers through NoC.
+        elif s.recv_from_noc.msg.cmd == CMD_PRELOAD_DATA:
+          if s.send_to_tile_store_request_addr_queue.recv.rdy & \
+             s.send_to_tile_store_request_data_queue.recv.rdy:
+            s.recv_from_noc.rdy @= 1
+            s.send_to_tile_store_request_addr_queue.recv.msg @= \
+                CGRAAddrType(received_pkt.addr)
+            s.send_to_tile_store_request_data_queue.recv.msg @= \
+                CGRADataType(received_pkt.data, received_pkt.predicate, 0, 0)
+            s.send_to_tile_store_request_addr_queue.recv.val @= s.recv_from_noc.val
+            s.send_to_tile_store_request_data_queue.recv.val @= s.recv_from_noc.val


I believe line 256 already handled these.

tancheng · 2025-01-19T18:54:58Z

controller/ControllerRTL.py

+                     0, # dst_y
+                     0,
+                     0,
+                     CMD_PRELOAD_CTRL,


Change this to CMD_CONFIG.

tancheng · 2025-01-19T19:10:49Z

controller/ControllerRTL.py

+                     0)
+
+      # For the data preloading.
+      # TODO: Where deos the preloading data for other controllers come from, recv_from_noc or recv_from_tile_store_request_pkt?


I think the most simple/straightforward way is:

s.crossbar.recv[kStoreRequestFromCpuInportIdx].val @= \ s.recv_ctrl_pkt_queue.send.val & (s.recv_ctrl_pkt_queue.send.msg.cmd_action == CMD_STORE_REQUEST) s.recv_ctrl_pkt_queue.send.rdy @= s.crossbar.recv[kStoreRequestFromCpuInportIdx].rdy

tancheng · 2025-01-19T19:15:59Z

controller/ControllerRTL.py

+      s.crossbar.recv[kPreloadCtrlIdx].val @= \
+          s.recv_ctrl_pkt_queue.send.val
+      s.recv_ctrl_pkt_queue.send.rdy @= s.crossbar.recv[kPreloadCtrlIdx].rdy
+      s.crossbar.recv[kPreloadCtrlIdx].msg @= \
+          NocPktType(controller_id,


I think this should depend on cpu msg type:

s.crossbar.recv[kPreloadCtrlIdx].val @= s.recv_ctrl_pkt_queue.send.val & (s.recv_ctrl_pkt_queue.send.msg.cmd_action == CMD_CONFIG) s.recv_ctrl_pkt_queue.send.rdy @= s.crossbar.recv[kPreloadCtrlIdx].rdy s.crossbar.recv[kPreloadCtrlIdx].msg @= \ NocPktType(controller_id,

tancheng · 2025-01-23T04:42:31Z

controller/ControllerRTL.py

@@ -20,7 +20,7 @@

 class ControllerRTL(Component):

-  def construct(s, ControllerIdType, CmdType, CtrlPktType, NocPktType,
+  def construct(s, ControllerIdType, CmdType, PreloadPktType, NocPktType,


Rename PreloadPktType to FromCpuPktType?

tancheng · 2025-01-23T04:43:07Z

controller/ControllerRTL.py


    @update
    def update_received_msg():
      kLoadRequestInportIdx = 0
      kLoadResponseInportIdx = 1
      kStoreRequestInportIdx = 2
+      kPreloadCtrlIdx = 3


kPreloadCtrlIdx -> kFromCpuCtrlIdx?

tancheng · 2025-01-23T04:43:21Z

controller/ControllerRTL.py


    @update
    def update_received_msg():
      kLoadRequestInportIdx = 0
      kLoadResponseInportIdx = 1
      kStoreRequestInportIdx = 2
+      kPreloadCtrlIdx = 3
+      kPreloaDataIdx = 4


kPreloaDataIdx -> kFromCpuDataIdx?

tancheng mentioned this pull request Jan 19, 2025

[P2] Installation and Data Preloading Issue #11: new data type #68

Open

tancheng reviewed Jan 19, 2025

View reviewed changes

yyan7223 requested a review from tancheng January 23, 2025 03:16

tancheng reviewed Jan 23, 2025

View reviewed changes

tancheng requested a review from yuqisun January 23, 2025 04:43

yyan7223 closed this Feb 4, 2025

yyan7223 force-pushed the master branch from 3308d5b to dbe6b94 Compare February 4, 2025 07:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial commit for ctrl&data preloading. #69

Initial commit for ctrl&data preloading. #69

yyan7223 commented Jan 19, 2025

yyan7223 commented Jan 19, 2025

yyan7223 commented Jan 19, 2025

tancheng commented Jan 19, 2025

tancheng commented Jan 19, 2025 •

edited

Loading

tancheng Jan 19, 2025

tancheng Jan 19, 2025

tancheng Jan 19, 2025

tancheng Jan 19, 2025

tancheng Jan 19, 2025

tancheng Jan 19, 2025

tancheng Jan 19, 2025

tancheng Jan 23, 2025

tancheng Jan 23, 2025

tancheng Jan 23, 2025

Initial commit for ctrl&data preloading. #69

Initial commit for ctrl&data preloading. #69

Conversation

yyan7223 commented Jan 19, 2025

yyan7223 commented Jan 19, 2025

yyan7223 commented Jan 19, 2025

tancheng commented Jan 19, 2025

tancheng commented Jan 19, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tancheng commented Jan 19, 2025 •

edited

Loading