-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): support smaller more frequent L2 blocks (replacing soft blocks) #18743
Draft
dantaik
wants to merge
18
commits into
pacaya_fork
Choose a base branch
from
pacaya_subblocks
base: pacaya_fork
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,457
−1,450
Draft
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
6112453
disable all TaikoInbox tests
dantaik 73888cb
add sub block configs
dantaik 1d55b38
support multiple blobs
dantaik 1f79800
rename 1
dantaik d63a3c7
rename 2
dantaik f393e0a
rename 4
dantaik 0c5c089
rename 4
dantaik 50d9037
clean up
dantaik bfb6ba9
rename 6
dantaik 8738c90
maxBlocksPerBatch: 2048
dantaik e677c5e
mainnet liveness bond now 1000 TAIKO
dantaik 4e705d4
remove difficulty from metadata
dantaik 32f234d
Update InboxTestBase.sol
dantaik 955eb15
more
dantaik bb65e28
fix
dantaik ac9f6e3
more
dantaik 870a346
fix
dantaik 0e8cbe0
blobIndices to numBlobs
dantaik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this design, when we propose blocks on L2, do we propose the batch or the blocks in the batch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We propose a batch. We move holistically across the stack from block based to batch based in this design, from proposing to proving.