feat(protocol): support smaller more frequent L2 blocks (replacing soft blocks) #18743
+1,457
−1,450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(protocol): support smaller more frequent L2 blocks (replacing soft blocks)
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
This was referenced Jan 10, 2025
| // The metadata must be supplied as calldata prior to proving the batch, enabling the | ||
| // computation and verification of its integrity through the comparison of the metahash. | ||
| unchecked { | ||
| meta_ = BatchMetadata({ |
There was a problem hiding this comment.
Shall we comment how to calculate block.difficulty here?
YoGhurt111
reviewed
Jan 10, 2025
| bytes32 txListHash; | ||
| bytes32 extraData; | ||
| address coinbase; | ||
| uint64 blockId; | ||
| uint64 batchId; |
There was a problem hiding this comment.
In this design, when we propose blocks on L2, do we propose the batch or the blocks in the batch?
There was a problem hiding this comment.
We propose a batch. We move holistically across the stack from block based to batch based in this design, from proposing to proving.
|
|
||
| _debitBond(_proposer, config.livenessBond * _paramsArray.length); | ||
| emit BlocksProposedV3(metas_, calldataUsed, _txList); | ||
| _debitBond(_proposer, config.livenessBond); |
There was a problem hiding this comment.
So rn for each batch, we only charge config.livenessBond once, is it by design?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces support for smaller and more frequent L2 blocks, replacing the previously planned soft-blocks. The primary motivation for this change stems from @cyberhorsey's discovery that most existing Ethereum SDKs and tools (e.g., MetaMask) do not handle frequent block reorganizations gracefully. Instead of investing effort into improving these libraries and tools, adopting smaller and more frequent blocks appears to be the most pragmatic solution.
Key Changes
In this PR, we introduce the concept of a "batch", which represents a collection of Taiko blocks. A batch serves as the smallest unit for block proposal, block proving, and cross-chain data synchronization. Block header data are derived from the same batch metadata to minimize on-chain footprint per block. This means that, given the same set of transactions within a batch, splitting them into 10 blocks versus 20 blocks does not significantly impact L1 gas costs—though there are still minor differences.
However, creating more L2 blocks from the same set of transactions does increase gas costs for batch proposals (slightly) and proving costs (more noticeable). Specifically, proofs are now aggregated in two stages:
More L2 blocks result in higher costs for the first level of aggregation.
Additionally, the protocol does not support proposing multiple batches in a single transaction. Instead, it leverages multiple blobs within a single
proposeBatchtransaction. As a result, proposers are encouraged to propose fewer and larger batches whenever possible to optimize efficiency.Review Tips
This is a large PR, but your primary focus should be on TaikoInbox.sol. The other changes are secondary and result from ripple effects.
Todos