-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚙️ Add the first page for the menu/settings tab #342
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
66d6735
Add the first page for the menu/settings tab
henryboldi 60fddd6
Add and use `SharedToggleButton` component
henryboldi 74e65e9
Remove useless fragment
henryboldi bf809fd
Merge branch 'main' into settings-tab
henryboldi 1659e64
Remove needless code wrapping `SettingsRow` in map
henryboldi fa2c9d2
Separate attributes for setting sections
henryboldi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
import React, { useState, ReactElement } from "react" | ||
import classNames from "classnames" | ||
|
||
export default function SharedToggleButton(): ReactElement { | ||
const [isActive, setIsActive] = useState(false) | ||
|
||
return ( | ||
<button | ||
type="button" | ||
className={classNames("container", { is_active: isActive })} | ||
onClick={() => { | ||
setIsActive(!isActive) | ||
}} | ||
> | ||
<div className="bulb" /> | ||
<style jsx> | ||
{` | ||
.container { | ||
width: 40px; | ||
height: 24px; | ||
border-radius: 20px; | ||
background-color: var(--green-80); | ||
box-sizing: border-box; | ||
padding: 4px; | ||
cursor: pointer; | ||
display: flex; | ||
} | ||
.bulb { | ||
width: 16px; | ||
height: 16px; | ||
border-radius: 20px; | ||
background-color: var(--green-40); | ||
transition: 0.2s ease-in-out; | ||
} | ||
.is_active .bulb { | ||
transform: translateX(16px); | ||
background-color: var(--trophy-gold); | ||
} | ||
`} | ||
</style> | ||
</button> | ||
) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a common pattern in react?
It might be easier to follow using the values inline in the template instead of using settings array and slice on it.
The Main Currency action might be a good candidate for putting it in a separate function though