⚙️ Add the first page for the menu/settings tab #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A WIP. I'd like to split out some of these pieces into their own component file. And this is all just visual.
Originally was in the Menu page itself
3b62288 to
74e65e9
Compare
itsrachelfish
suggested changes
Oct 19, 2021
greg-nagy
reviewed
Oct 19, 2021
ui/pages/Menu.tsx
Outdated
| <div className="icon_lock" /> | ||
| <h3>General</h3> | ||
| <ul> | ||
| {settings.slice(0, 4).map((setting) => { |
There was a problem hiding this comment.
Is this a common pattern in react?
It might be easier to follow using the values inline in the template instead of using settings array and slice on it.
The Main Currency action might be a good candidate for putting it in a separate function though
Co-authored-by: Rachel Fish <itsrachelfish@gmail.com>
Co-authored-by: Rachel Fish <itsrachelfish@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings tab
This aims to eventually allow users to edit extension-wide settings. Currently, this is all just visual components on the first page. That said, the toggle button does flip between off and on when clicked with a smooth transition.