Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "save image" button #29

Merged
merged 1 commit into from
Sep 27, 2016
Merged

Add "save image" button #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions static/panes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,12 @@ function Pane(id) {
cloneButton.innerHTML = 'o';
cloneButton.title = 'disconnect';

var saveButton = document.createElement('a');
saveButton.innerHTML = '⤓';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to have something easier to read. The arrow is rather thin and hard to tell apart.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about http://www.fileformat.info/info/unicode/char/2b07/index.htm?

saveButton.title = 'save';
saveButton.download = 'untitled_image.jpg';
saveButton.href = '';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make it show up only if the content is savable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I wasn't aware that the content can be unsavable. When can this happen? I thought the panes only show up for images and charts.


var title = document.createElement('div');
title.className = 'title';

Expand All @@ -129,12 +135,14 @@ function Pane(id) {
this.grip = grip;
this.title = title;
this.content = content;
this.saveButton = saveButton;

el.appendChild(grip);
el.appendChild(bar);
el.appendChild(content);
bar.appendChild(closeButton);
bar.appendChild(cloneButton);
bar.appendChild(saveButton);
bar.appendChild(title);
body.appendChild(el);

Expand Down Expand Up @@ -188,6 +196,7 @@ function Pane(id) {
Pane.prototype = {
setTitle: function(title) {
this.title.innerHTML = title;
this.saveButton.download = title.replace(/\s+/g, '_') + '.jpg';
},

focus: function() {
Expand Down Expand Up @@ -481,6 +490,7 @@ ImagePane.prototype = extend(Object.create(Pane.prototype), {
// Hack around unexpected behavior. Setting .src resets .style (except 'position: absolute').
var oldCss = this.content.style.cssText;
this.content.src = content.src;
this.saveButton.href = content.src;
this.content.style.cssText = oldCss;
if (this.content.style.cssText != oldCss) {
this.content.style.cssText = oldCss;
Expand Down
12 changes: 10 additions & 2 deletions static/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,19 @@ button {
cursor: pointer;
}

button:hover {
.bar a {
color: black;
text-decoration: none;
font-size: 12px;
line-height: 14px;
}

button:hover, a:hover {
font-weight: bold;
}

.bar button {

.bar button, .bar a {
background: transparent;
margin: 0 4px;
float: left;
Expand Down