Add "save image" button #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This solves #27 |
szym
reviewed
Sep 27, 2016
| @@ -117,6 +117,12 @@ function Pane(id) { | |||
| cloneButton.innerHTML = 'o'; | |||
| cloneButton.title = 'disconnect'; | |||
|
|
|||
| var saveButton = document.createElement('a'); | |||
| saveButton.innerHTML = '⤓'; | |||
There was a problem hiding this comment.
It'd be nice to have something easier to read. The arrow is rather thin and hard to tell apart.
There was a problem hiding this comment.
szym
reviewed
Sep 27, 2016
| saveButton.innerHTML = '⤓'; | ||
| saveButton.title = 'save'; | ||
| saveButton.download = 'untitled_image.jpg'; | ||
| saveButton.href = ''; |
There was a problem hiding this comment.
We should make it show up only if the content is savable.
There was a problem hiding this comment.
Oh, I wasn't aware that the content can be unsavable. When can this happen? I thought the panes only show up for images and charts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a button to the bar that saves the currently displayed image.