Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cookbook][Security] Added doc for x509 pre authenticated listener #3913

Merged
merged 5 commits into from
Jun 9, 2014

Conversation

zefrog
Copy link

@zefrog zefrog commented Jun 6, 2014

Q A
Doc fix? no
New docs? yes
Applies to 2.3+
Fixed tickets -

This can be merged in 2.3. Regards.

@@ -16,5 +16,6 @@ Security
securing_services
custom_provider
custom_authentication_provider
pre_authenticated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be added to /cookbook/map.rst.inc.

@zefrog
Copy link
Author

zefrog commented Jun 6, 2014

Thank you for your feedback!

Using pre Authenticated Security Firewalls
==========================================

A lot of authentication modules are already provided by some webservers,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "web servers" is a bit more correct?

@weaverryan weaverryan merged commit 57cc957 into symfony:2.3 Jun 9, 2014
weaverryan added a commit that referenced this pull request Jun 9, 2014
…ed listener (zefrog)

This PR was merged into the 2.3 branch.

Discussion
----------

[Cookbook][Security] Added doc for x509 pre authenticated listener

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | 2.3+
| Fixed tickets | -

This can be merged in 2.3. Regards.

Commits
-------

57cc957 full xml config, pushed the note at the end of the entry
01d18fe fixing last issues in pre_authenticated cookbook entry
83c40e9 Corrected pre_authenticated cookbook entry
f5a6d58 Added pre_authenticated to map.rst
6c9a204 [Cookbook][Security] x509 doc for pre authenticated listeners
@weaverryan
Copy link
Member

Thanks so much for this @zefrog! It's a really well-explained article :). I've opened up #3921 because I have a few small todos that I will still like to do to make this article even clearer. And as you'll see, the question about SSL_CLIENT_S_DN is still unresolved - we should definitely look into this - it's not even being used in the code itself.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants