-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X-509 Certificate: Clarify user provider and credentials #3921
Labels
Comments
zefrog
pushed a commit
to zefrog/symfony-docs
that referenced
this issue
Jun 10, 2014
weaverryan
added a commit
that referenced
this issue
Jun 11, 2014
…uration parameter (zefrog) This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Security] Explicit 'your_user_provider' configuration parameter Following @weaverryan #3921 first improvement, I've added a few lines to the bottom note of the article, to be more precise about the ``provider`` configuration key. Commits ------- 0f0376f #3921 - explicit 'your_user_provider' configuration parameter
Ticked the first one, as it seems te be fixed by #3927 |
I'm closing this old issue because the pending thing about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This follows after #3913, which is a really nice article about pre-auth and X509. I still have 2 things I'd like to improve:
1) Near the end of the article, we use
your_user_provider
in the code example as the user provider. Below, I think we should explicitly mention this string again. For example:2) I don't think our note on
SSL_CLIENT_S_DN
is correct. See my note about this value (second paragraph) in this comment: [Cookbook][Security] Added doc for x509 pre authenticated listener #3913 (comment). Basically, it appears that this value is never used during authentication (https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Security/Core/Authentication/Provider/PreAuthenticatedAuthenticationProvider.php#L63) and is not available later to the user on the authenticated token. So, I'm not sure at all what this "credentials" is used for. It could even be a code bug.The text was updated successfully, but these errors were encountered: