Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacemacs-purpose-popwin name #7441

Merged
merged 1 commit into from
Oct 17, 2016
Merged

Fix spacemacs-purpose-popwin name #7441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...s/+spacemacs/spacemacs-purpose/local/spacemacs-purpose-popwin/spacemacs-purpose-popwin.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,5 +240,5 @@ variables are updated instead."
(ad-update 'popwin:create-popup-window)))
(add-hook 'pupo-mode-hook #'pupo/sync-advices)

(provide 'purpose-popwin)
(provide 'spacemacs-purpose-popwin)
;;; purpose-popwin.el ends here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed the "ends here" line, and also the very first line in the file ("purpose-popwin.el --- [...]").

4 changes: 2 additions & 2 deletions layers/+spacemacs/spacemacs-purpose/packages.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,11 @@
(add-hook 'purpose-mode-hook #'spacemacs/window-purpose-sync-popwin)
(spacemacs/window-purpose-sync-popwin))))

(defun spacemacs-purpose/init-purpose-popwin ()
(defun spacemacs-purpose/init-spacemacs-purpose-popwin ()
(use-package spacemacs-purpose-popwin
;; don't load spacemacs-purpose-popwin if popwin is excluded.
;; can't wrap `spacemacs-purpose/init-purpose-popwin' in a top-level `when'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but while we're at it we can delete these 2 comments as well.

:init
:config
(progn
(pupo-mode)
;; override popwin commands with pupo commands
Expand Down