Fix spacemacs-purpose-popwin name #7441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is in. |
bmag
reviewed
Oct 17, 2016
| @@ -240,5 +240,5 @@ variables are updated instead." | |||
| (ad-update 'popwin:create-popup-window))) | |||
| (add-hook 'pupo-mode-hook #'pupo/sync-advices) | |||
|
|
|||
| (provide 'purpose-popwin) | |||
| (provide 'spacemacs-purpose-popwin) | |||
| ;;; purpose-popwin.el ends here | |||
There was a problem hiding this comment.
Missed the "ends here" line, and also the very first line in the file ("purpose-popwin.el --- [...]").
| @@ -83,11 +83,11 @@ | |||
| (add-hook 'purpose-mode-hook #'spacemacs/window-purpose-sync-popwin) | |||
| (spacemacs/window-purpose-sync-popwin)))) | |||
|
|
|||
| (defun spacemacs-purpose/init-purpose-popwin () | |||
| (defun spacemacs-purpose/init-spacemacs-purpose-popwin () | |||
| (use-package spacemacs-purpose-popwin | |||
| ;; don't load spacemacs-purpose-popwin if popwin is excluded. | |||
| ;; can't wrap `spacemacs-purpose/init-purpose-popwin' in a top-level `when' | |||
There was a problem hiding this comment.
Not related to this PR, but while we're at it we can delete these 2 comments as well.
5 tasks
|
Thanks @bmag, I just pushed those fixes manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7439