check for dbus before add erc-notify hook. #2681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSX doesn't have dbus support. 'erc-global-notify makes a call to notifications which relies on dbus. Check to see if dbus-compiled-version exists before adding hook. Note: This variable is added in emacs 24.3. There may be a better way to check for dbus support.
|
I'd like to wait to hear from someone using erc-terminal-notifier for osx before having this brought in to make sure it doesn't break anything. |
|
Will hear from any issue soon enough in develop branch ;-P |
|
Oops.... didn't mean to reopen it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emcs for OSX doesn't have dbus support by default. 'erc-global-notify makes a call to
notifications which seems to rely on dbus. Check to see if
dbus-compiled-version exists before adding hook.
Note: This variable is added in emacs 24.3. There may be a better way to
check for dbus support.
See #2324