Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC notifications not working correctly on OS X #2324

Closed
gunnarhelgason opened this issue Jul 14, 2015 · 5 comments
Closed

ERC notifications not working correctly on OS X #2324

gunnarhelgason opened this issue Jul 14, 2015 · 5 comments
Labels
- Bug tracker - IRC macOS stale marked as a stale issue/pr (usually by a bot)

Comments

@gunnarhelgason
Copy link

I've enabled the erc layer in .spacemacs and installed the terminal-notifier gem. However, instead of receiving notifications I get the following error in emacs: error in process filter: peculiar error: "Emacs not compiled with dbus support"

If I add (require 'erc-terminal-notifier) to my .spacemacs, the notifications are delivered to the OS X notification center, but the dbus error persists.

The documentation for the erc layer does not specify that you have to do anything special (other than installing terminal-notifier) to get notifications to work on OS X. Is this a bug, or have I misunderstood something? I assume that at least the dbus error is a bug as dbus isn't available on OS X AFAIK.

@CestDiego
Copy link
Contributor

Sorry cannot reproduce ;_; don't have osx. :3 maybe one of the osx users can help.

@cmccloud
Copy link
Contributor

I was having a similar error. I don't make use of notifications in my own erc configuration, but the error seems to be coming from this block of code:

      (defun erc-global-notify (match-type nick message)
        "Notify when a message is recieved."
        (notifications-notify
         :title nick
         :body message
         :app-icon "/home/io/.emacs.d/assets/spacemacs.svg"
         :urgency 'low))

      (add-hook 'erc-text-matched-hook 'erc-global-notify)

notifications-notify requires d-bus.
I fixed it by adding the following line to my post-erc configuration:

(remove-hook 'erc-text-matched-hook 'erc-global-notify)

@gunnarhelgason if you try this out and it works for you let me know and I'll look into making a change to the erc package layer to only add that hook if it detects dbus support.

@asheshambasta
Copy link

@cmccloud sorry if this is a stale issue and I'm bringing it up again – but I can still reproduce this even with

(remove-hook 'erc-text-matched-hook 'erc-global-notify)

At the end of my init file.

@Miciah
Copy link
Contributor

Miciah commented Jun 8, 2018

Are you on macOS? What do you get if you open the eval prompt (M-:) and enter (bound-and-true-p dbus-compiled-version)?

andrestylianos pushed a commit to andrestylianos/spacemacs that referenced this issue Jun 25, 2018
… changes

The function `cider-current-repl-buffer` does not exist anymore in cider after PR [syl20bnr#2324](clojure-emacs/cider#2324) was merged.
It broke the usage of functions in the clojure layer that sent used `spacemacs//cider-eval-in-repl-no-focus`, which sends forms to be evaluated in the repl buffer without focusing on it.
The fix is to use `cider-current-repl` instead of `cider-current-repl-buffer`
sdwolfz pushed a commit that referenced this issue Jul 3, 2018
… changes

The function `cider-current-repl-buffer` does not exist anymore in cider after PR [#2324](clojure-emacs/cider#2324) was merged.
It broke the usage of functions in the clojure layer that sent used `spacemacs//cider-eval-in-repl-no-focus`, which sends forms to be evaluated in the repl buffer without focusing on it.
The fix is to use `cider-current-repl` instead of `cider-current-repl-buffer`
CodingSolo pushed a commit to CodingSolo/spacemacs that referenced this issue Oct 29, 2018
… changes

The function `cider-current-repl-buffer` does not exist anymore in cider after PR [syl20bnr#2324](clojure-emacs/cider#2324) was merged.
It broke the usage of functions in the clojure layer that sent used `spacemacs//cider-eval-in-repl-no-focus`, which sends forms to be evaluated in the repl buffer without focusing on it.
The fix is to use `cider-current-repl` instead of `cider-current-repl-buffer`
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Bug tracker - IRC macOS stale marked as a stale issue/pr (usually by a bot)
Projects
None yet
Development

No branches or pull requests

7 participants