Modernize advice definition using advice-add #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace old defadvice form with modern advice-add syntax for er/prepare-for-more-expansions-internal. This maintains the same functionality while using the preferred advice system introduced in Emacs 24.4.
fnussbaum
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Thanks for this PR! It might be better to use a named advice instead of a lambda, which would be easier to remove in user configurations (for example to aid debugging):
(define-advice er/prepare-for-more-expansions-internal
(:around (orig-fun &rest args) evil-iedit-state)
(let* ((result (apply orig-fun args))
(default-msg (car result))
(default-bindings (cdr result)))
(cons (concat default-msg ", e to edit")
(add-to-list 'default-bindings
'("e" evil-iedit-state/iedit-mode-from-expand-region)))))as suggested by @fnussbaum
|
Ah yes, I see that is better to name it for the reasons you explain. Changed and thanks for the tip! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modernized the advice definition by replacing the old
defadviceform with the moderndefine-advicesyntax.Changes
defadvicewithdefine-adviceforer/prepare-for-more-expansions-internalTesting Done
This change requires Emacs 24.4 or later (which is already required by the package dependencies).