evil-iedit/emacs 31.01: defadvice obsolte

[dannywillems]

With Emacs 31.0, we're getting this warning:

Warning: ‘defadvice’ is an obsolete macro (as of 30.1); use ‘advice-add’ or ‘define-advice’

Full message:

../../../.emacs.d/elpa/31.0/develop/evil-iedit-state-20220219.1432/evil-iedit-state-autoloads.el: Warning: ‘defadvice’ is an obsolete macro (as of 30.1); use ‘advice-add’ or ‘define-advice’

Coming from here: https://github.com/syl20bnr/evil-iedit-state/blob/master/evil-iedit-state.el.

Is it a plugin we can get rid of?

[bcc32]

This package is still used (e.g., by pressing SPC s e). I use it pretty regularly for things like variable renaming, for example.

I think we should just update the package to use define-advice instead. Looks like somebody has opened a pull request to do so: syl20bnr/evil-iedit-state#39.

[smile13241324]

I have made a quick fork and incorporated the required changes from the PR of @durantschoon. When the package is updated it will be pulled from our fork instead.