Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ld-path driver option #67956

Merged
merged 2 commits into from
Sep 5, 2023
+5 −1
Merged

Add ld-path driver option #67956

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b628852
Add ld-path driver option
kabiroberai Aug 16, 2023
49a38f7
Mark --ld-path as HelpHidden
kabiroberai Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion include/swift/Option/Options.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,7 +890,11 @@ def no_static_executable : Flag<["-"], "no-static-executable">,

def use_ld : Joined<["-"], "use-ld=">,
Flags<[DoesNotAffectIncrementalBuild]>,
HelpText<"Specifies the linker to be used">;
HelpText<"Specifies the flavor of the linker to be used">;

def ld_path : Joined<["--"], "ld-path=">,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the -- form rather than - form?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to match the spelling in Clang, which also simplifies forwarding the option; though I don't have a strong preference so I can change this to a single dash if you'd prefer.

Flags<[DoesNotAffectIncrementalBuild, ArgumentIsPath]>,
HelpText<"Specifies the path to the linker to be used">;

def Xlinker : Separate<["-"], "Xlinker">,
Flags<[DoesNotAffectIncrementalBuild]>,
Expand Down