Add ld-path driver option #67956
Merged
Add ld-path driver option #67956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 16, 2023
MaxDesiatov
approved these changes
Aug 16, 2023
|
@swift-ci test |
|
@swift-ci build toolchain |
artemcm
approved these changes
Aug 16, 2023
artemcm
reviewed
Aug 16, 2023
|
@artemcm would be great if we could kick off CI here + in the swift-driver PR |
|
@swift-ci test |
|
@swift-ci build toolchain |
compnerd
reviewed
Aug 17, 2023
| HelpText<"Specifies the linker to be used">; | ||
| HelpText<"Specifies the flavor of the linker to be used">; | ||
|
|
||
| def ld_path : Joined<["--"], "ld-path=">, |
There was a problem hiding this comment.
Why the -- form rather than - form?
There was a problem hiding this comment.
I wanted to match the spelling in Clang, which also simplifies forwarding the option; though I don't have a strong preference so I can change this to a single dash if you'd prefer.
MaxDesiatov
pushed a commit
to swiftlang/swift-driver
that referenced
this pull request
Sep 5, 2023
This PR introduces an `--ld-path` option, which is forwarded to the Clang linker-driver option with the same name. This change is required to support the `toolset.linker.path` option in [SE-0387](https://github.com/apple/swift-evolution/blob/main/proposals/0387-cross-compilation-destinations.md). ## See also Upstream: swiftlang/swift#67956. Downstream: swiftlang/swift-package-manager#6719.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines an
--ld-pathoption for the Swift Driver, which is forwarded to the Clang linker-driver option with the same name. This change is required to support thetoolset.linker.pathoption in SE-0387.See Also
Downstream: swiftlang/swift-driver#1416, swiftlang/swift-package-manager#6719.