Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Speed up benchmark action by sharding #10152

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 6, 2025

@kdy1 kdy1 added this to the Planned milestone Mar 6, 2025
@kdy1 kdy1 self-assigned this Mar 6, 2025
@kdy1 kdy1 requested a review from a team as a code owner March 6, 2025 15:59
Copy link

changeset-bot bot commented Mar 6, 2025

⚠️ No Changeset found

Latest commit: 34040fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 6, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 6, 2025
Copy link

codspeed-hq bot commented Mar 6, 2025

CodSpeed Performance Report

Merging #10152 will not alter performance

Comparing kdy1/bench-shard (67c0250) with main (b993f86)

Summary

✅ 152 untouched benchmarks
⁉️ 47 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ es/full/bugs-1 446.6 µs N/A N/A
⁉️ es/full/minify/libraries/antd 3.4 s N/A N/A
⁉️ es/full/minify/libraries/d3 605.2 ms N/A N/A
⁉️ es/full/minify/libraries/echarts 2.5 s N/A N/A
⁉️ es/full/minify/libraries/jquery 168.1 ms N/A N/A
⁉️ es/full/minify/libraries/lodash 180.7 ms N/A N/A
⁉️ es/full/minify/libraries/moment 108 ms N/A N/A
⁉️ es/full/minify/libraries/react 31.3 ms N/A N/A
⁉️ es/full/minify/libraries/terser 496.2 ms N/A N/A
⁉️ es/full/minify/libraries/three 1 s N/A N/A
⁉️ es/full/minify/libraries/typescript 5.4 s N/A N/A
⁉️ es/full/minify/libraries/victory 1.4 s N/A N/A
⁉️ es/full/minify/libraries/vue 229.4 ms N/A N/A
⁉️ es/oxc/benches/assets/UserSettings.tsx/sourceMap=false/reactDev=false 1.1 ms N/A N/A
⁉️ es/oxc/benches/assets/UserSettings.tsx/sourceMap=false/reactDev=true 1.2 ms N/A N/A
⁉️ es/oxc/benches/assets/UserSettings.tsx/sourceMap=true/reactDev=false 1.4 ms N/A N/A
⁉️ es/oxc/benches/assets/UserSettings.tsx/sourceMap=true/reactDev=true 1.6 ms N/A N/A
⁉️ es/oxc/benches/assets/parser.ts/sourceMap=false/reactDev=false 71.9 ms N/A N/A
⁉️ es/oxc/benches/assets/parser.ts/sourceMap=false/reactDev=true 71.9 ms N/A N/A
⁉️ es/oxc/benches/assets/parser.ts/sourceMap=true/reactDev=false 104 ms N/A N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@kdy1 kdy1 merged commit b76410d into main Mar 6, 2025
167 checks passed
@kdy1 kdy1 deleted the kdy1/bench-shard branch March 6, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Faster "Benchmark" workflow with sharded CodSpeed uploads
1 participant