Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster "Benchmark" workflow with sharded CodSpeed uploads #10148

Closed
fargito opened this issue Mar 5, 2025 · 2 comments · Fixed by #10152
Closed

Faster "Benchmark" workflow with sharded CodSpeed uploads #10148

fargito opened this issue Mar 5, 2025 · 2 comments · Fixed by #10152
Assignees
Milestone

Comments

@fargito
Copy link

fargito commented Mar 5, 2025

Hello,

I'm a member of CodSpeed, and I saw that you were using it to run benchmarks.

We recently released a feature to enable sharded benchmark reports. Since on this repo, the "Benchmark" workflow can take between 45 minutes and 6 hours, I figured you could greatly benefit from this feature.

Basically, each crate can now run its own benchmarks independently. The whole aggregation will be done on CodSpeed infrastructure. Here, it would also mean that the benchmarks no longer have to run on the self-hosted instance. You can view the sharded benchmarks documentation here.

If you want, I can open a pull request to use this new approach in the "Benchmark" workflow. Also since I developed this feature, I'd be happy to help if there are any issues with it.

@kdy1 kdy1 self-assigned this Mar 6, 2025
@kdy1 kdy1 added this to the Planned milestone Mar 6, 2025
@kdy1
Copy link
Member

kdy1 commented Mar 6, 2025

It would be really nice if you can create a PR. Thank you so much in advance!

@kdy1
Copy link
Member

kdy1 commented Mar 6, 2025

I'll work on it because I want to try it asap 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants