Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to .NET Core 2.1 #8764

Closed
wants to merge 1 commit into from
Closed

Conversation

knom
Copy link
Contributor

@knom knom commented Oct 1, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Updated ASPNET Core Generator to support .NET Core 2.1.
As per https://docs.microsoft.com/en-us/dotnet/core/migration/20-21

@jimschubert @wing328

@knom
Copy link
Contributor Author

knom commented Oct 1, 2018

This is solving #8761

@knom
Copy link
Contributor Author

knom commented Nov 6, 2018

@wing328 can you merge this?

@jimschubert
Copy link
Contributor

@knom we've moved to our own fork (https://github.com/OpenAPITools/openapi-generator), and neither of us have commit access to this project.

openapi-generator had a similar PR a couple months ago. See OpenAPITools/openapi-generator#1008

@knom knom closed this Oct 16, 2019
@frantuma frantuma reopened this Apr 20, 2020
@frantuma frantuma added this to the M1 milestone Apr 20, 2020
@HugoMario
Copy link
Contributor

already covered

@HugoMario HugoMario closed this Apr 22, 2020
@knom knom deleted the aspnetcore-2.1 branch May 11, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants