Update the Asp.Net core server generator to support Asp.net Core 2.1 #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, remove the web.config file.
…s as aposed to Controller.
…erty and an env parameter to the Configure method.
… method from asp.net core 2.1.
Upgrade NoteTo fall back to ASP.NET core 2.0, please set {
"aspnetCoreVersion": "2.0"
}or --additional-properties aspnetCoreVersion="2.0" |
|
I think the README must also be updated to 2.1 |
wing328
reviewed
Sep 18, 2018
| @@ -0,0 +1,18 @@ | |||
| FROM microsoft/aspnetcore-build:2.0 AS build-env | |||
There was a problem hiding this comment.
@SeanFarrow do we need to update the line 1 and 15 to use microsoft/aspnetcore-build:2.1 instead?
|
@cbornet I believe you're referring to the project's README as I couldn't find "2.0" in |
|
No, I refer to the generated README : https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/aspnetcore/2.1/README.mustache#L1 |
|
@wing328,
Ideally, yes.
From: William Cheng <notifications@github.com>
Sent: 18 September 2018 16:14
To: OpenAPITools/openapi-generator <openapi-generator@noreply.github.com>
Cc: Sean Farrow <sean.farrow@seanfarrow.co.uk>; Mention <mention@noreply.github.com>
Subject: Re: [OpenAPITools/openapi-generator] Update the Asp.Net core server generator to support Asp.net Core 2.1 (#1008)
@wing328 commented on this pull request.
________________________________
In modules/openapi-generator/src/main/resources/aspnetcore/2.1/Dockerfile.mustache<#1008 (comment)>:
@@ -0,0 +1,18 @@
+FROM microsoft/aspnetcore-build:2.0 AS build-env
@SeanFarrow<https://github.com/SeanFarrow> do we need to update the line 1 and 15 to use microsoft/aspnetcore-build:2.1 instead?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1008 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABY1fiReydIiqv61CrJjO-Z-rpyWFHl7ks5ucQ2rgaJpZM4Wh04u>.
|
|
@wing328, |
jaumard
pushed a commit
to jaumard/openapi-generator
that referenced
this pull request
Sep 21, 2018
…penAPITools#1008) * Update the .net core sdk to v2.1 and update the asp.net packages used. * Upgrade the SwashBuckle Asp.Net Core package to v3.0.0. * Update the AppSettings json file and add a file used in development. Also, remove the web.config file. * Update the program template to use the web host builder class. * Update the startup class to use the Asp.Net 2.1 paradigms. * Update the launch settings json file. * Update the controller template to derive from the ControllerBase class as aposed to Controller. * Add the SwashBuckle annotations package. * Add the SwashBuckle.AspNetCore.Annotations namespace to the controller template. * Update the Startup template to add comments to the Configuration property and an env parameter to the Configure method. * Update the startup class so we don't need to inject the hosting environment. * Update the program class to have hte recommended CreateWebHostBuilder method from asp.net core 2.1. * Update the asp.net core pet store sample server. * add back aspnetcore 2.0 template via option * remove web.config for aspnet core 2.1
|
@SeanFarrow thanks again adding the ASP.net Core 2.1 support, which is included in the v3.3.0 minor release: https://twitter.com/oas_generator/status/1046941449609068544 |
4 tasks
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…penAPITools#1008) * Update the .net core sdk to v2.1 and update the asp.net packages used. * Upgrade the SwashBuckle Asp.Net Core package to v3.0.0. * Update the AppSettings json file and add a file used in development. Also, remove the web.config file. * Update the program template to use the web host builder class. * Update the startup class to use the Asp.Net 2.1 paradigms. * Update the launch settings json file. * Update the controller template to derive from the ControllerBase class as aposed to Controller. * Add the SwashBuckle annotations package. * Add the SwashBuckle.AspNetCore.Annotations namespace to the controller template. * Update the Startup template to add comments to the Configuration property and an env parameter to the Configure method. * Update the startup class so we don't need to inject the hosting environment. * Update the program class to have hte recommended CreateWebHostBuilder method from asp.net core 2.1. * Update the asp.net core pet store sample server. * add back aspnetcore 2.0 template via option * remove web.config for aspnet core 2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Asp.Net server generator to support Asp.Net core 2.1. It fixes issue #999.