forked from apache/carbondata
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
review Query #1
Open
sujith71955
wants to merge
690
commits into
Branch_master_CodeReview
Choose a base branch
from
master
base: Branch_master_CodeReview
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
review Query #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor CarbonIterator * rename
[Issue 421]Formatted Scala code and added code style template
since the filter value resolving mechanism is increasing the code has been re factored also for accommodating such extensions
fix for complex datatypes data load failing, due to data load merge sort optimization impact
*Supported retension feature ex: DELETE SEGMENTS FROM TABLE TABLENAME where STARTTIME before '2016-05-10 00:00:00' *Moved required code to SegmentStatusManager *Refactored and removed duplicate code from existing Util class
handle exception in MDKeyGenStep
Correct the readCount of MDK (apache#452)
…hrow directly (apache#454) * MalformedCarbonCommandException is raised in carbon parse errors, so that it will not fall back to hive parser. * add trim for each dictionary_include/exclude value
* remove useless code * modify code * modify code * reset complex example * fix issue * fix
…umns, throws indexOutOfBound (apache#527)
…iolates its general contract! " when nodictionary column is present. (apache#525)
…arsing issue (apache#511) * Fixing struct field underscore issue and struct<struct> parsing issue * Adding Testcase * changed class comment
* When struct data type data has more number of values then desired columns, throws indexOutOfBound (apache#515) * Fix bug in UnsafeComparer.INSTANCE.compareTo(PR#523) Fix bug " Comparison method violates its general contract" * auto identify high cardinality column in first load * add test case and fix review comments * change to new formula
…ache#522) * fix the bug of null array columns during data loading * add sth * add sth
fix testcase
…hen schema This closes apache#21
Fixed hdfs folder path issue which contains '-' Reverted commented testcase code
fix typos Update Quick-Start.md fix typo Update Quick-Start.md Fix typo for Quick-Start
modify doc for new tblproperties modify doc for new tblproperties
Make the derby db metastore configurable. Fixed review comments Fixed test case compile error Fixed test cases Fixed integration test case Fixed style
Fixed relative path issue of metastore location
… unused code Simplified the storage name
…carbondata This closes apache#32
sujith71955
pushed a commit
that referenced
this pull request
May 23, 2018
* Modified MDs for PdfGeneration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.