Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Carbondata-390] float data type supported #480

Closed
wants to merge 8 commits into from

Conversation

rahulk2
Copy link
Contributor

@rahulk2 rahulk2 commented Dec 29, 2016

Float data type supported with spark 1.6 and spark 2.0.

@CarbonDataQA
Copy link

Build Failed with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/374/

@CarbonDataQA
Copy link

Build Failed with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/375/

@CarbonDataQA
Copy link

Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/379/

@@ -85,12 +85,15 @@
}

@Override public CarbonReadDataHolder getValues(int decimal, Object maxValueObject) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the way you supposed to do, please check how long data type is supported.

@ravipesala
Copy link
Contributor

rename title from [Carbondata 390] to [CARBONDATA-390]

@rahulk2 rahulk2 changed the title [Carbondata 390] float data type supported [Carbondata-390] float data type supported Jan 5, 2017
@ravipesala
Copy link
Contributor

@rahulforallp Thank you for working on it.
But another PR https://github.com/apache/incubator-carbondata/pull/521 with simple changes are merged to master, so please close this PR

@rahulk2
Copy link
Contributor Author

rahulk2 commented Jan 16, 2017

Ok, thanks for you support

@rahulk2 rahulk2 closed this Jan 16, 2017
Beyyes pushed a commit to Beyyes/carbondata that referenced this pull request Jul 12, 2018
Fix: Job metrics page show 1 job & job metrics page gpu memory usage unit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants