-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release 0.1.0 #295
chore: release 0.1.0 #295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for initiating this.
One question: can you also update the https://github.com/substrait-io/substrait-validator?tab=readme-ov-file#substrait-version-support section in this PR?
Ah, yes, good catch! Will do. |
| Substrait... | ... is supported by validator ... | | ||
| --------------- | ---------------------------------------------- | | ||
| 0.57.x | 0.1.0 (current version) | | ||
| 0.21.x - 0.56.x | try 0.0.11 or 0.1.0, but your mileage may vary | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repo was fairly quiet for some time, so I don't think we've tested compatibility here, hence the large gap with the vague recommendation
Rust: https://github.com/substrait-io/substrait-validator/actions/runs/11711071490 ✅ Looks like we need a fix for the Python wheel artifact issue. |
Hm, yes. I'm not quite sure what the problem is - it might be that we have N jobs attempting to upload |
This was a breaking change in the There are some suggestions in actions/upload-artifact#480. I added #296. |
Judging from here, it looks like dependabot's upgrade of
I'm happy to make a PR here, although you know this part of the code better than I do, @mbrobbel! |
This PR
Closes #290.
This PR is:
python ci/version.py set 0.1.0
.Cargo.toml
, which appears on crates.ioI went with 0.1.0 because the jump in substrait version supported like more than just a patch version change, although I'm not sure it matters pre-1.0; if others have opinions, it would be trivial to switch this to 0.0.12 instead.
Releasing
After this is merged, based on what I saw earlier, I think all we need to do is add a tag (e.g. via the Github web interface) of the form
v*.*.*
and CI should take it from there - building and publishing to crates.io and to PyPI.Followup