Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 0.1.0 #295

Merged
merged 3 commits into from
Nov 6, 2024
Merged

chore: release 0.1.0 #295

merged 3 commits into from
Nov 6, 2024

Conversation

wackywendell
Copy link
Contributor

@wackywendell wackywendell commented Nov 6, 2024

This PR

Closes #290.

This PR is:

  1. First commit is purely codegen from running python ci/version.py set 0.1.0.
  2. Second commit updates the repository info in Cargo.toml, which appears on crates.io
  3. Third commit updates the substrait compatibility matrix in the README

I went with 0.1.0 because the jump in substrait version supported like more than just a patch version change, although I'm not sure it matters pre-1.0; if others have opinions, it would be trivial to switch this to 0.0.12 instead.

Releasing

After this is merged, based on what I saw earlier, I think all we need to do is add a tag (e.g. via the Github web interface) of the form v*.*.* and CI should take it from there - building and publishing to crates.io and to PyPI.

Followup

  1. Fix any issues with CI if release doesn't go smoothly
  2. Update the docs to clarify that adding a tag is enough to trigger an automated release.

@wackywendell wackywendell marked this pull request as ready for review November 6, 2024 16:19
Copy link
Member

@mbrobbel mbrobbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for initiating this.

One question: can you also update the https://github.com/substrait-io/substrait-validator?tab=readme-ov-file#substrait-version-support section in this PR?

@wackywendell
Copy link
Contributor Author

One question: can you also update the https://github.com/substrait-io/substrait-validator?tab=readme-ov-file#substrait-version-support section in this PR?

Ah, yes, good catch! Will do.

| Substrait... | ... is supported by validator ... |
| --------------- | ---------------------------------------------- |
| 0.57.x | 0.1.0 (current version) |
| 0.21.x - 0.56.x | try 0.0.11 or 0.1.0, but your mileage may vary |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo was fairly quiet for some time, so I don't think we've tested compatibility here, hence the large gap with the vague recommendation

@mbrobbel mbrobbel changed the title Cut a release chore: release 0.1.0 Nov 6, 2024
@mbrobbel mbrobbel merged commit b2c0297 into substrait-io:main Nov 6, 2024
37 checks passed
@mbrobbel
Copy link
Member

mbrobbel commented Nov 6, 2024

@wackywendell
Copy link
Contributor Author

Looks like we need a fix for the Python wheel artifact issue.

Hm, yes. I'm not quite sure what the problem is - it might be that we have N jobs attempting to upload wheels.zip, and only one can succeed? So perhaps they should each be attempting to upload wheels-${ARCH}-${PYTHON_VERSION}?

@mbrobbel
Copy link
Member

mbrobbel commented Nov 6, 2024

This was a breaking change in the v4 release of the download/upload artifact actions: https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes

There are some suggestions in actions/upload-artifact#480.

I added #296.

@wackywendell
Copy link
Contributor Author

Judging from here, it looks like dependabot's upgrade of actions/upload-artifact from 3 to 4 led to this:

Unlike earlier versions of upload-artifact, uploading to the same artifact via multiple jobs is not supported with v4

Artifact names must be unique since each created artifact is idempotent so multiple jobs cannot modify the same artifact.

I'm happy to make a PR here, although you know this part of the code better than I do, @mbrobbel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release a new version
2 participants