Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release a new version #290

Closed
wackywendell opened this issue Nov 5, 2024 · 6 comments · Fixed by #295
Closed

Release a new version #290

wackywendell opened this issue Nov 5, 2024 · 6 comments · Fixed by #295

Comments

@wackywendell
Copy link
Contributor

There's been a suite of recent changes to substrait-validator, and it would be useful to release a new version, as mentioned briefly here.

I'm opening this issue to raise the question - what features or changes (outside the documented release chores) do we want before we're ready for a new version?

@mbrobbel
Copy link
Member

mbrobbel commented Nov 5, 2024

In my opinion we can just bump versions and push a new release now and repeat this whenever beneficial.

@westonpace
Copy link
Member

In my opinion we can just bump versions and push a new release now and repeat this whenever beneficial.

Agreed. Ideally we could automate the release steps in the future too so that we can have push-button releases.

@wackywendell
Copy link
Contributor Author

Ah, ok! Fair enough.

🤔 I'm not sure how automated it currently is / how well it will work; it looks like there's a Github Action for releasing (Python too), so if we tag the commit with a version number that should trigger it? I guess we'll have to see how functional that is 🤞

I can put together a PR for that. @mbrobbel - did you want to get #276 in first? It looks like that would update the Python packager maturin, which might affect this.

@mbrobbel
Copy link
Member

mbrobbel commented Nov 6, 2024

did you want to get #276 in first?

No, let's not block this release on that.

@wackywendell
Copy link
Contributor Author

OK! I'll put together a PR for that. Any thoughts on the version number?

We're currently at 0.0.11; perhaps its time to go to 0.1.0? This seems like more than a patch update, but pre-1.0 I'm not sure it matters much...

@wackywendell
Copy link
Contributor Author

^ OK! I made a PR. I went with 0.1.0 for now, but its real easy to switch if there are other opinions. Thanks for your help on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants