Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated backport of #2822: Create xtables.lock as a file if it doesn't already exist #2845

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Automated backport of #2822: Create xtables.lock as a file if it doesn't already exist #2845

merged 2 commits into from
Oct 19, 2023

Conversation

skitt
Copy link
Member

@skitt skitt commented Oct 13, 2023

Backport of #2822 on release-0.14.

#2822: Create xtables.lock as a file if it doesn't already exist

For details on the backport process, see the backport requests page.

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2845/skitt/automated-backport-of-#2822-origin-release-0.14
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@sridhargaddam sridhargaddam enabled auto-merge (rebase) October 13, 2023 07:56
@sridhargaddam
Copy link
Member

@skitt there are some errors.

#4 242.4 # github.com/submariner-io/submariner-operator/controllers/submariner
#4 242.4 controllers/submariner/globalnet_resources.go:73:41: undefined: ptr
#4 242.4 controllers/submariner/route_agent_resources.go:77:41: undefined: ptr
#4 246.1 make: *** [Makefile:132: bin/linux/amd64/submariner-operator] Error 2
#4 246.1 make: Leaving directory '/go/src/github.com/submariner-io/submariner-operator'
#4 ERROR: process "/bin/sh -c make -C ${SOURCE} LOCAL_BUILD=1 bin/${TARGETPLATFORM}/submariner-operator" did not complete successfully: exit code: 2

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Oct 13, 2023
@skitt @tpantelis
Create xtables.lock as a file if it doesn't already exist
b02c657 
Default host path mounts create a directory if the mounted path
doesn't correspond to anything, which ends up breaking iptables. This
fixes that by ensuring that xtables.lock is created as a file if it
doesn't already exist; subsequent invocations of iptables on the host
(if any) will then be able to use the new file for locking.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@tpantelis tpantelis force-pushed the automated-backport-of-#2822-origin-release-0.14 branch from f7afa8f to b02c657 Compare October 19, 2023 13:33
@sridhargaddam sridhargaddam merged commit e1ee091 into submariner-io:release-0.14 Oct 19, 2023
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2845/skitt/automated-backport-of-#2822-origin-release-0.14]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpantelis tpantelis tpantelis approved these changes

@sridhargaddam sridhargaddam sridhargaddam approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

Assignees
No one assigned
Labels
automated-backport ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skitt @submariner-bot @sridhargaddam @tpantelis