Create xtables.lock as a file if it doesn't already exist #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default host path mounts create a directory if the mounted path doesn't correspond to anything, which ends up breaking iptables. This fixes that by ensuring that xtables.lock is created as a file if it doesn't already exist; subsequent invocations of iptables on the host (if any) will then be able to use the new file for locking. Signed-off-by: Stephen Kitt <skitt@redhat.com>
|
🤖 Created branch: z_pr2822/skitt/qualify-xtables-host-path |
|
This seems to cause a vulnerability error. |
The vulnerability is a false positive, see github/advisory-database#2742 |
OK. I changed the job to required - did you make it non-required due to this? |
Yes — we can wait for the advisory fix to be merged, or “unrequire” the job until it’s fixed... |
dfarrell07
approved these changes
Sep 21, 2023
tpantelis
approved these changes
Sep 21, 2023
sridhargaddam
approved these changes
Sep 25, 2023
|
🤖 Closed branches: [z_pr2822/skitt/qualify-xtables-host-path] |
This was referenced Oct 13, 2023
tpantelis
added a commit
to skitt/submariner-operator
that referenced
this pull request
Oct 19, 2023
…2822-origin-release-0.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default host path mounts create a directory if the mounted path doesn't correspond to anything, which ends up breaking iptables. This fixes that by ensuring that xtables.lock is created as a file if it doesn't already exist; subsequent invocations of iptables on the host (if any) will then be able to use the new file for locking.