Restore route agent node update privilege #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr2225/tpantelis/restore_routeagent_priv |
The route agent needs to update the "submariner.io/cniIfaceIp" annotation on nodes for globalnet. This caused E2E failures, eg https://github.com/submariner-io/lighthouse/runs/8154953193?check_suite_focus=true Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
dedd80d to
3f9a8dd
Compare
skitt
approved these changes
Sep 2, 2022
dfarrell07
approved these changes
Sep 2, 2022
|
🤖 Closed branches: [z_pr2225/tpantelis/restore_routeagent_priv] |
tpantelis
added a commit
to tpantelis/subctl
that referenced
this pull request
Sep 2, 2022
...to pick up the changes in submariner-io/submariner-operator#2225 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
added a commit
to submariner-io/subctl
that referenced
this pull request
Sep 5, 2022
...to pick up the changes in submariner-io/submariner-operator#2225 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
skitt
added a commit
to skitt/submariner-operator
that referenced
this pull request
Nov 3, 2022
... including follow-up partial reverts in submariner-io#2214 and submariner-io#2225. Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
added a commit
to skitt/submariner-operator
that referenced
this pull request
Nov 3, 2022
... including follow-up partial reverts in submariner-io#2214 and submariner-io#2225. Signed-off-by: Stephen Kitt <skitt@redhat.com>
dfarrell07
added a commit
to dfarrell07/submariner-operator
that referenced
this pull request
Nov 11, 2022
The submariner-gateway RBAC for pods duplicates the get permission, as it's granted * elsewhere. This was recently modified in submariner-io#2225 and submariner-io#2008. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
dfarrell07
added a commit
to dfarrell07/submariner-operator
that referenced
this pull request
Nov 11, 2022
The RBAC for pods duplicates the get permission, as it's granted * elsewhere. This was recently modified in submariner-io#2225, submariner-io#2214, and submariner-io#2008. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
sridhargaddam
pushed a commit
to dfarrell07/submariner-operator
that referenced
this pull request
Dec 17, 2022
The RBAC for pods duplicates the get permission, as it's granted * elsewhere. This was recently modified in submariner-io#2225, submariner-io#2214, and submariner-io#2008. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The route agent needs to update the
submariner.io/cniIfaceIpannotation on nodes for globalnet. This caused E2E failures, eg https://github.com/submariner-io/lighthouse/runs/8154953193?check_suite_focus=true.The privilege was recently removed by #2008.