Reduce route-agent and gateway privileges #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr2008/skitt/reduce-ra-gateway-permissions |
1d02e36 to
5d694d7
Compare
5d694d7 to
5f77e9c
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
5f77e9c to
4d7343f
Compare
4d7343f to
9dc9eda
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This drops unnecessary privileges frmo the route-agent and gateway: they don't need to modify pods, notes, secrets, or persistentvolumeclaims. Signed-off-by: Stephen Kitt <skitt@redhat.com>
e152c47 to
bc988b5
Compare
tpantelis
approved these changes
Aug 8, 2022
dfarrell07
approved these changes
Aug 8, 2022
|
🤖 Closed branches: [z_pr2008/skitt/reduce-ra-gateway-permissions] |
tpantelis
added a commit
to tpantelis/submariner-operator
that referenced
this pull request
Aug 26, 2022
The gateway is failing trying to update labels on its own pod: main.go:416] Error updating pod label: Error patching own pod "submariner-gateway-jqc9v"...forbidden: User "system:serviceaccount:submariner-operator:submariner-gateway" cannot patch resource "pods" PR submariner-io#2008 removed the "pods" privilege for the gateway role but it turns out it's needed. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
skitt
pushed a commit
that referenced
this pull request
Aug 29, 2022
The gateway is failing trying to update labels on its own pod: main.go:416] Error updating pod label: Error patching own pod "submariner-gateway-jqc9v"...forbidden: User "system:serviceaccount:submariner-operator:submariner-gateway" cannot patch resource "pods" PR #2008 removed the "pods" privilege for the gateway role but it turns out it's needed. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
skitt
added a commit
to skitt/submariner-operator
that referenced
this pull request
Nov 3, 2022
... including follow-up partial reverts in submariner-io#2214 and submariner-io#2225. Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
added a commit
to skitt/submariner-operator
that referenced
this pull request
Nov 3, 2022
... including follow-up partial reverts in submariner-io#2214 and submariner-io#2225. Signed-off-by: Stephen Kitt <skitt@redhat.com>
dfarrell07
added a commit
to dfarrell07/submariner-operator
that referenced
this pull request
Nov 10, 2022
The submariner-gateway RBAC for pods duplicates the get permission, as it's granted * elsewhere. This was recently modified in submariner-io#2214 and submariner-io#2008. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
dfarrell07
added a commit
to dfarrell07/submariner-operator
that referenced
this pull request
Nov 10, 2022
The submariner-gateway RBAC for pods duplicates the get permission, as it's granted * elsewhere. This was recently modified in submariner-io#2214 and submariner-io#2008. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
dfarrell07
added a commit
to dfarrell07/submariner-operator
that referenced
this pull request
Nov 11, 2022
The submariner-gateway RBAC for pods duplicates the get permission, as it's granted * elsewhere. This was recently modified in submariner-io#2225 and submariner-io#2008. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
dfarrell07
added a commit
to dfarrell07/submariner-operator
that referenced
this pull request
Nov 11, 2022
The RBAC for pods duplicates the get permission, as it's granted * elsewhere. This was recently modified in submariner-io#2225, submariner-io#2214, and submariner-io#2008. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
sridhargaddam
pushed a commit
to dfarrell07/submariner-operator
that referenced
this pull request
Dec 17, 2022
The RBAC for pods duplicates the get permission, as it's granted * elsewhere. This was recently modified in submariner-io#2225, submariner-io#2214, and submariner-io#2008. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops unnecessary privileges frmo the route-agent and gateway:
they don't need to modify pods, notes, secrets, or
persistentvolumeclaims.
Signed-off-by: Stephen Kitt skitt@redhat.com