Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsteady CHT #854

Merged
merged 33 commits into from
Feb 26, 2020
Merged

Unsteady CHT #854

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
708121a
Tidy up CHeatIteration by inheriting from CFluidIteration.
oleburghardt Jan 29, 2020
9d4e408
Small fix in CHeatFVMVariable so that it can be used in unsteady runs.
oleburghardt Jan 29, 2020
02eea23
Quick solution to set same physical time step in all zones for unstea…
oleburghardt Jan 29, 2020
f35f260
Add test case incomp_2d_unsteady (basically incomp_2d with additional…
oleburghardt Jan 29, 2020
18af1de
Merge branch 'develop' of https://github.com/su2code/SU2 into feature…
oleburghardt Jan 29, 2020
7ce063e
added time convergence monitoring for multizone driver
ScSteffen Jan 29, 2020
34aa908
Merge branch 'feature_unsteady_cht' of https://github.com/su2code/SU2…
ScSteffen Jan 29, 2020
da8a691
Small revert.
oleburghardt Jan 30, 2020
dbc8ff7
Merge branch 'feature_unsteady_cht' of https://github.com/su2code/SU2…
oleburghardt Jan 30, 2020
9ce9811
Quick solution to fix missing reference time in heat solvers (this ne…
oleburghardt Jan 31, 2020
4a6344c
Increasing Reynolds number (by higher density) in unsteady CHT test c…
oleburghardt Jan 31, 2020
64a170d
Change test case parameters.
oleburghardt Feb 3, 2020
18fa12a
Merge branch 'develop' into feature_unsteady_cht
talbring Feb 3, 2020
b8dd47c
Adapt unsteady CHT test case parameters to prepare it as regression t…
oleburghardt Feb 5, 2020
36e4291
Add unsteady CHT case to regression tests.
oleburghardt Feb 5, 2020
60358b6
Merge branch 'develop' of https://github.com/su2code/SU2 into feature…
oleburghardt Feb 5, 2020
725ceee
Merge branch 'feature_unsteady_cht' of https://github.com/su2code/SU2…
oleburghardt Feb 5, 2020
b8f571e
Small fix.
oleburghardt Feb 5, 2020
008c35a
Another small fix.
oleburghardt Feb 5, 2020
4cebf34
Yet another small fix for unsteady regression test.
oleburghardt Feb 5, 2020
382e82f
Adapt to parallel regression test values.
oleburghardt Feb 6, 2020
772756a
Replace fixed value hack for multizone reference time adjustment by a…
oleburghardt Feb 6, 2020
8e27cf8
Improve comment.
oleburghardt Feb 6, 2020
4606456
Quick workaround for multizone reference times incorporating the FEA …
oleburghardt Feb 7, 2020
d103c4a
(Correct) quick workaround for multizone reference times incorporatin…
oleburghardt Feb 7, 2020
7061830
Small change for Time_Ref initialization.
oleburghardt Feb 7, 2020
0e4f584
Merge branch 'develop' of https://github.com/su2code/SU2 into feature…
oleburghardt Feb 7, 2020
6702690
Merge branch 'develop' of https://github.com/su2code/SU2 into feature…
oleburghardt Feb 10, 2020
99f5284
Merge branch 'develop' of https://github.com/su2code/SU2 into feature…
oleburghardt Feb 18, 2020
c3c114c
Remove 'FVM' extensions from all names related to the finite volume h…
oleburghardt Feb 18, 2020
0796772
Typos and spaces.
oleburghardt Feb 25, 2020
cac5f03
Merge branch 'develop' of https://github.com/su2code/SU2 into feature…
oleburghardt Feb 25, 2020
fd49a59
Small change (adding paranthesis around booleans).
oleburghardt Feb 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions SU2_CFD/src/drivers/CMultizoneDriver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,10 @@ void CMultizoneDriver::StartSolver() {

driver_config->Set_StartTime(StartTime);

for (iZone = 0; iZone < nZone; iZone++) {
config_container[iZone]->SetDelta_UnstTimeND(config_container[ZONE_0]->GetDelta_UnstTimeND());
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ugly and if someone has got the time right now, I'd like to have your suggestions what the 'right' approach might be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's improved now by taking the minimum of all reference times as the reference time for all zones (not requiring any hard-coded values).

/*--- Main external loop of the solver. Runs for the number of time steps required. ---*/

if (rank == MASTER_NODE)
Expand Down