Unsteady CHT #854

oleburghardt · 2020-01-29T13:40:28Z

Proposed Changes

These are rather smaller changes and fixes so that the unsteady multizone framework can be used for CHT.

A test case together with a tutorial (mainly on how - and how easy it is - to turn a steady simulation into an unsteady one) will be added.

Related Work

Tutorial
Trailer on Youtube ;-)

@TobiKattmann @ScSteffen Please follow this so that we can set up Unsteady Adjoint CHT computations afterwards.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags).
My contribution is commented and consistent with SU2 style.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

…dy multizone runs. This needs to be improved.

oleburghardt · 2020-01-29T13:42:05Z

SU2_CFD/src/drivers/CMultizoneDriver.cpp

+  for (iZone = 0; iZone < nZone; iZone++) {
+    config_container[iZone]->SetDelta_UnstTimeND(config_container[ZONE_0]->GetDelta_UnstTimeND());
+  }
+


This is ugly and if someone has got the time right now, I'd like to have your suggestions what the 'right' approach might be.

It's improved now by taking the minimum of all reference times as the reference time for all zones (not requiring any hard-coded values).

… options to turn it into its unsteady version).

…_unsteady_cht

…into feature_WND

…into feature_unsteady_cht

…eds to be improved even more).

…ase for better unsteady effects.

…est.

…_unsteady_cht

…into feature_unsteady_cht

…pplying the minimum value.

…_unsteady_cht

…eat solver.

pcarruscag

Have you checked that "suggest-parenthesis" warning? This would be a good PR to solve that.

pcarruscag · 2020-02-19T13:33:03Z

SU2_CFD/include/iteration_structure.hpp

+   void Solve(COutput *output,
+              CIntegration ****integration,


this is one space out of alignment

To me it looks good and it does not say 'Outdated' 😕 (concerning @pcarruscag 's comment)

void is 3 spaces from the margin 🤓

TobiKattmann

Hi Ole,
thanks for this PR and especially for the tutorial and the video (that is also embedded in the tutorial-website) 💐 in my opinion this is really valuable

I have just a few comments below
(if you add the comments in the .cfg's please do that for the tutorial as well)

Cheers Tobi

TobiKattmann · 2020-02-24T14:38:04Z

SU2_CFD/include/drivers/CMultizoneDriver.hpp

@@ -131,4 +131,11 @@ class CMultizoneDriver : public CDriver {

  bool Monitor(unsigned long TimeIter);

+  /*!
+     * \brief  Returns wheter all specified windowed-time-averaged ouputs have been converged


whether typo

TobiKattmann · 2020-02-24T14:43:43Z

SU2_CFD/include/iteration_structure.hpp

+   void Solve(COutput *output,
+              CIntegration ****integration,


To me it looks good and it does not say 'Outdated' 😕 (concerning @pcarruscag 's comment)

TobiKattmann · 2020-02-24T14:45:16Z

SU2_CFD/include/iteration_structure.hpp

@@ -747,19 +732,18 @@ class CHeatIteration : public CIteration {
   * \param[in] surface_movement - Surface movement classes of the problem.
   * \param[in] grid_movement - Volume grid movement classes of the problem.
   * \param[in] FFDBox - FFD FFDBoxes of the problem.
-   * \param[in] val_iZone - zone of the problem.


not sure why you removed val_iZone ? val_iInst is missing as well

They are missing everywhere. I think one should add those consistently.

TobiKattmann · 2020-02-24T14:46:47Z

SU2_CFD/include/solvers/CHeatSolver.hpp

- * \author O. Burghardt
+ * \file CHeatSolver.hpp
+ * \brief Headers of the CHeatSolver class
+ * \author F. Palacios, T. Economon


Unimportant ... but why did you change the file author?

It's a very minor correction. Don't know why, maybe for consistency. There are no real guidelines for that anyway.

"If you wrote everything you are the author" than seems to be the rule no?

TobiKattmann · 2020-02-24T14:49:46Z

SU2_CFD/src/drivers/CSinglezoneDriver.cpp

    /*--- Check whether the outer time integration has reached the final time ---*/

+    TimeConvergence = GetTimeConvergence();


..., or windowed time-average converged ---*/ as a comment enhancement suggestion

@ScSteffen Please check

TobiKattmann · 2020-02-24T15:42:24Z

SU2_CFD/src/iteration_structure.cpp

+  /*--- For steady-state flow simulations, we need to loop over ExtIter for the number of time steps ---*/
+  /*--- However, ExtIter is the number of FSI iterations, so nIntIter is used in this case ---*/


ExtIter is out of date, right? So I wonder whether this comment is still valid alltogehter

I think CHeatIteration is not the best place to start with correcting such comments. E.g. CFluidIteration is the most important iteration class and practically one can adapt only from there to have everything aligned. But you're still right, so feel free to replace it if you like :-)

TobiKattmann · 2020-02-24T15:51:47Z

TestCases/coupled_cht/incomp_2d_unsteady/cht_2d_3cylinders.cfg

+%
+%
+TIME_DOMAIN = YES
+%
+%
+TIME_MARCHING= DUAL_TIME_STEPPING-2ND_ORDER
+%


As regression test cases and especially tutorial cases are probably early points of contact with people newer around SU2, I would like to have the config_template.cfg comment for the option pasted here (which is hopefully correct) and logically seperated like in the zone specific files. Like that is a little bit more self-explaining and displays possible alternative options.

But this comment is more of general nature

oleburghardt · 2020-02-25T10:21:37Z

Have you checked that "suggest-parenthesis" warning? This would be a good PR to solve that.

@pcarruscag Are those displayed by -Wall? Just checked that in that case there are no such "suggest paranthesis" warnings.

…_unsteady_cht

pcarruscag · 2020-02-25T10:55:01Z

I don't know what option that warning is included with, or if the behaviour is different across compiler versions.
I compile with with -Wall -Wextra, nevertheless please check the line I pointed to in your previous PR, I would gladly silence the warning but I don't know how that logic is supposed to work.

oleburghardt · 2020-02-25T11:17:35Z

Ok. I'm still getting no warnings even with -Wall -Wextra.
But just to be sure I added some extra paranthesis around boolean operations in the code lines that you have referenced in my former PR.

pcarruscag · 2020-02-25T11:19:24Z

👍 What compiler (and version) do you use?

oleburghardt · 2020-02-25T11:25:38Z

gcc 9.2.1 :)

pcarruscag · 2020-02-25T11:29:41Z

Here you go, Wall is enough.

oleburghardt · 2020-02-25T11:36:37Z

Good to know, thanks! 👍 The problem must have been solved by someone else before then (the latest commit with extra paranthesis is not a correction in that regard).

pcarruscag · 2020-02-25T11:50:44Z

Hmm, someone fixed it in this branch then, because develop still has it, anyway its fixed.

oleburghardt · 2020-02-25T13:39:25Z

:-) Ok. Right know I'm trying to fix a bug for writing out surface sensitivities for the CHT cases in the repo. (It's probably not specific to CHT but a more general multizone problem.)

It would fit quite well here, so please hold on a second with merging!

pcarruscag

@oleburghardt I'm merging this to resolve the conflicts with #861 and merge that one after.

oleburghardt added 3 commits January 29, 2020 14:30

Tidy up CHeatIteration by inheriting from CFluidIteration.

708121a

Small fix in CHeatFVMVariable so that it can be used in unsteady runs.

9d4e408

Quick solution to set same physical time step in all zones for unstea…

02eea23

…dy multizone runs. This needs to be improved.

pr-triage bot added the PR: draft label Jan 29, 2020

oleburghardt commented Jan 29, 2020

View reviewed changes

pr-triage bot added PR: unreviewed and removed PR: draft labels Jan 29, 2020

Add test case incomp_2d_unsteady (basically incomp_2d with additional…

f35f260

… options to turn it into its unsteady version).

pr-triage bot added PR: draft and removed PR: unreviewed labels Jan 29, 2020

oleburghardt and others added 9 commits January 29, 2020 14:58

Merge branch 'develop' of https://github.com/su2code/SU2 into feature…

18af1de

…_unsteady_cht

added time convergence monitoring for multizone driver

7ce063e

Merge branch 'feature_unsteady_cht' of https://github.com/su2code/SU2 …

34aa908

…into feature_WND

Small revert.

da8a691

Merge branch 'feature_unsteady_cht' of https://github.com/su2code/SU2 …

dbc8ff7

…into feature_unsteady_cht

Quick solution to fix missing reference time in heat solvers (this ne…

9ce9811

…eds to be improved even more).

Increasing Reynolds number (by higher density) in unsteady CHT test c…

4a6344c

…ase for better unsteady effects.

Change test case parameters.

64a170d

Merge branch 'develop' into feature_unsteady_cht

18fa12a

oleburghardt mentioned this pull request Feb 4, 2020

Unsteady CHT tutorial su2code/su2code.github.io#26

Merged

oleburghardt added 10 commits February 5, 2020 12:08

Adapt unsteady CHT test case parameters to prepare it as regression t…

b8dd47c

…est.

Add unsteady CHT case to regression tests.

36e4291

Merge branch 'develop' of https://github.com/su2code/SU2 into feature…

60358b6

…_unsteady_cht

Merge branch 'feature_unsteady_cht' of https://github.com/su2code/SU2 …

725ceee

…into feature_unsteady_cht

Small fix.

b8f571e

Another small fix.

008c35a

Yet another small fix for unsteady regression test.

4cebf34

Adapt to parallel regression test values.

382e82f

Replace fixed value hack for multizone reference time adjustment by a…

772756a

…pplying the minimum value.

Improve comment.

8e27cf8

Merge branch 'develop' of https://github.com/su2code/SU2 into feature…

0e4f584

…_unsteady_cht

pr-triage bot added PR: draft and removed PR: unreviewed labels Feb 7, 2020

oleburghardt marked this pull request as ready for review February 7, 2020 14:12

pr-triage bot added PR: unreviewed and removed PR: draft labels Feb 7, 2020

cvencro mentioned this pull request Feb 10, 2020

Dynamic FSI Adjoint #868

Closed

5 tasks

oleburghardt added 3 commits February 10, 2020 10:29

Merge branch 'develop' of https://github.com/su2code/SU2 into feature…

6702690

…_unsteady_cht

Merge branch 'develop' of https://github.com/su2code/SU2 into feature…

99f5284

…_unsteady_cht

Remove 'FVM' extensions from all names related to the finite volume h…

c3c114c

…eat solver.

pcarruscag reviewed Feb 19, 2020

View reviewed changes

talbring added the changelog:fix label Feb 22, 2020

TobiKattmann approved these changes Feb 24, 2020

View reviewed changes

oleburghardt added 2 commits February 25, 2020 11:49

Typos and spaces.

0796772

Merge branch 'develop' of https://github.com/su2code/SU2 into feature…

cac5f03

…_unsteady_cht

Small change (adding paranthesis around booleans).

fd49a59

pcarruscag approved these changes Feb 26, 2020

View reviewed changes

pcarruscag merged commit f1776de into develop Feb 26, 2020

pcarruscag deleted the feature_unsteady_cht branch February 26, 2020 14:18

pr-triage bot added PR: merged and removed PR: unreviewed labels Feb 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unsteady CHT #854

Unsteady CHT #854

oleburghardt commented Jan 29, 2020 •

edited

Loading

oleburghardt Jan 29, 2020

oleburghardt Feb 7, 2020

pcarruscag left a comment

pcarruscag Feb 19, 2020

TobiKattmann Feb 24, 2020

pcarruscag Feb 24, 2020

TobiKattmann left a comment

TobiKattmann Feb 24, 2020

TobiKattmann Feb 24, 2020

TobiKattmann Feb 24, 2020

oleburghardt Feb 25, 2020

TobiKattmann Feb 24, 2020

oleburghardt Feb 25, 2020

pcarruscag Feb 25, 2020

TobiKattmann Feb 24, 2020

oleburghardt Feb 25, 2020

TobiKattmann Feb 24, 2020

oleburghardt Feb 25, 2020

TobiKattmann Feb 24, 2020

oleburghardt commented Feb 25, 2020 •

edited

Loading

pcarruscag commented Feb 25, 2020

oleburghardt commented Feb 25, 2020

pcarruscag commented Feb 25, 2020

oleburghardt commented Feb 25, 2020

pcarruscag commented Feb 25, 2020

oleburghardt commented Feb 25, 2020

pcarruscag commented Feb 25, 2020

oleburghardt commented Feb 25, 2020

pcarruscag left a comment

		/--- Check whether the outer time integration has reached the final time ---/

		TimeConvergence = GetTimeConvergence();

		/--- For steady-state flow simulations, we need to loop over ExtIter for the number of time steps ---/
		/--- However, ExtIter is the number of FSI iterations, so nIntIter is used in this case ---/

Unsteady CHT #854

Unsteady CHT #854

Conversation

oleburghardt commented Jan 29, 2020 • edited Loading

Proposed Changes

Related Work

PR Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pcarruscag left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TobiKattmann left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oleburghardt commented Feb 25, 2020 • edited Loading

pcarruscag commented Feb 25, 2020

oleburghardt commented Feb 25, 2020

pcarruscag commented Feb 25, 2020

oleburghardt commented Feb 25, 2020

pcarruscag commented Feb 25, 2020

oleburghardt commented Feb 25, 2020

pcarruscag commented Feb 25, 2020

oleburghardt commented Feb 25, 2020

pcarruscag left a comment

Choose a reason for hiding this comment

oleburghardt commented Jan 29, 2020 •

edited

Loading

oleburghardt commented Feb 25, 2020 •

edited

Loading