-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regressions for all convective numerical schemes for NEMO #1885
Conversation
As mentioned, these all use the same geometry, and I happy to discuss inclusion of different test cases. Also, I noticed that mutation++ does have a regression case, do we not compile M++ for regression builds? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, definitely important to get test coverage on these schemes!
Sounds like all these tested cases run, do you have a comparison of convergence history? I'd be curious if they have similar performance on this test case, and would be good to confirm correct behavior past 10 iters.
I do not have a good grasp on the performance of each scheme. I fear that may be a much time-intensive task, particularly since these all are implicit at the moment. |
I'm thinking just run this test case out to convergence for each scheme then comparing convergence histories. That way if any don't converge, we know we're not grandfathering in broken cases/schemes. |
…2code/SU2 into feature_nemo_ausm_regressions
Here is a quick summary for the inviscid wedge case using different NEMO schemes. There is clearly work to be done in the convergence/robustness world. |
…2code/SU2 into feature_nemo_ausm_regressions
I am adding regressions for all the convective numerical schemes in NEMO using the implicit solver. All cases run on an inviscid wedge at the moment, but I am happy to make a new folder in the regression.
Related Work
This will allow us to better track our changes and is the start of a more comprehensive set of regression tests for the Nemo solver coming in the future (boundary conditions, etc.)
This directly relates to #1773 to eventually refactor the AUSM schemes.
PR Checklist