-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction of AUSM+M and AUSM scheme refactoring in NEMO #1773
Conversation
Not for this PR, but the documentation update the NEMO team should consider is this one https://su2code.github.io/docs_v7/Convective-Schemes/, the config_template is not much use for users since it does not say what schemes can be used with what fluid models. |
This pull request introduces 2 alerts when merging 84cdb7e into d32ccec - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 787c7ea into bc6ef2a - view on LGTM.com new alerts:
|
…code/SU2 into feature_NEMO_AUSMPLUSM_clean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, I think the refactoring makes sense. Thanks Wally!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work with the refactoring 👍
Run clang-format on the new files please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran clang-format (because we want to make a release this Monday) LGTM on my side we can move those functions another day.
Proposed Changes
This PR makes several changes to the NEMO code:
1.) @fmpmorgado Introduced the AUSM+M convective scheme that avoids the carbuncle phenomena in hypersonic blunt bodies (https://doi.org/10.1016/j.apm.2019.09.005)
2.) Wally - A full refactoring of the AUSM schemes within NEMO
3.) Removal of AUSMPW+ scheme
Related Work
This work is a follow-up and a cleaner version of the work in the branch feature_NEMO_AUSMPLUSM. I will delete both branches after merge.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
Benchmark
I have conducted a comparison between the AUSM and AUSM+M for a 2D axisymmetric non-equilibrium flow over a cylinder with a 0.1 meter diameter and a freestream of M=24, P = 10.23 N and T = 224.5 K.
The left image represents the converged 2nd order solution using AUSM+M and the right image using the standard AUSM scheme. The new AUSM+M scheme enables to get rid of the pressure oscillations near the stagnation area.
Temperature at the stagnation line (solid line is AUSM+M and dashed line is AUSM)
Pressure at the stagnation line and close-up at the stagnation point (solid line is AUSM+M and dashed line is AUSM)