This repository has been archived by the owner on Jun 30, 2024. It is now read-only.
Only insert semicolons inside of CSS #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #334? Any idea when we can merge this? |
|
Hey @anduong96 thanks for reminding me I’ll try to take a look at this later on today |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #299 and #351
Uses the patterns from
syntaxes/styled-components.jsonand regex to determine if the cursor is within CSS and enable or disable semicolon insertion accordingly.srcto.in tsconfig to allow importing grammarsattrsorwithConfig(that regex seems to work a bit differently and would probably take a bit of extra work to fix)