-
Notifications
You must be signed in to change notification settings - Fork 117
Auto-completion affects non-styled syntax which resulting in semicolon suffix in Object. #299
Comments
I switched to v1.5.2, and it's fine. |
@iamyoki would you be interested in working on this bug? |
Does it have any config to disable this feature? (I haven't found it) |
You can change the version back to 1.5.2 as suggested by @iamyoki |
I will put in an option to toggle this feature |
Is someone able to knock up a small test case? Im unable to reproduce this issue :/ I think it may be fixable without having to disable it but for that i need a tiny test case |
@jasonwilliams I tried to find a way to reproduce it, but I don't know how... However, I found it was caused by 'extension.insertColonOrSemiColon' command.
|
I can reproduce this issue in any object. @jasonwilliams the following typeScript code reproduces the issue:
it seems like any object key that is also a css property causes a problem |
Hmm I think we should just get rid of this feature and hope the typescript css/sass service can provide it instead. @RJWadley id accept a PR which just removes this command. I don’t think there’s any good way to know when we’re in a good place to enable it on/off |
Description
When I typing inside original style, it triggers vscode-styled-components auto-completion with semicolon suffix.
Screenshot
![2021-05-28 14 11 54](https://user-images.githubusercontent.com/74389358/119939119-ef564800-bfbf-11eb-8230-a628ee959152.gif)
Expected behavior
Don't bother original style syntax.
Build environment (please complete the following information):
The text was updated successfully, but these errors were encountered: