🐛 Fix popover and dropdown on mobile sidebar #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronleopold
approved these changes
Nov 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed my previous PR introduced an issue on mobile viewports 😱 :
before.mp4
This PR fixes the issue! I took some time to look at the other uses of
<DropdownMenu/>to make sure they work as expected in mobile and desktop viewports. Also fixed UserMenu's Popover which was having the same issue as shown above.after.mp4
Separately, I noticed some small UI issues that only happened if the viewport was exactly
768pxso I took care of those as well:Screenshots
Before
After