Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix unresponsive app after closing modal within dropdown #497

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

xendke
Copy link
Contributor

@xendke xendke commented Nov 3, 2024

I noticed there is an issue where if you open a dropdown menu and one of the items opens a modal, once the modal is closed the app becomes unresponsive to clicks until you refresh the page.

Recording.2024-11-03.152110.mp4

Here is the radix-ui issue that talks about it. Although it is marked as fixed, some folks are still running into this issue.

This PR fixes the issue but with the drawback that you can interact with the outside of the dropdown menu while it's open.
I can keep looking into it if we think that's worth it but regardless this is probably a better UX than what is happening right now.

Copy link
Collaborator

@aaronleopold aaronleopold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes the issue but with the drawback that you can interact with the outside of the dropdown menu while it's open

I assume that means you can't click out of it, either? Regardless I agree, though,a freeze is definitely not the more ideal UX. This should be more than acceptable for now.

Thanks for finding, outlining, and fixing exactly what was wrong - I really appreciate it!

@xendke
Copy link
Contributor Author

xendke commented Nov 4, 2024

when you click outside of the dropdown it does close but that same click that closes the menu will interact with whatever you clicked on, here's a before and after:

before.mp4

with fix:

after.mp4

thanks your attention on this tiny fix! feel free to merge 🙇

@aaronleopold aaronleopold merged commit f238317 into stumpapp:experimental Nov 4, 2024
@aaronleopold aaronleopold mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants