Fix split terminal bug #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/stripeTerminal.ts
Outdated
| const terminal = await this.createNewSplitTerminal(); | ||
| if (!terminal) { | ||
| throw new Error('Failed to split Stripe terminal'); |
There was a problem hiding this comment.
Should we say try again on error? I'm slightly confused what a Stripe terminal is. What do you think?
There was a problem hiding this comment.
Good question. I don't think we want to retry because to reach this exception, then something very wrong must have happened.
A Stripe terminal is a vscode terminal whose sole purpose is to run stripe commands. I'm not sure if there's a better name for it, happy to change it if you have any suggestions.
There was a problem hiding this comment.
Oops sorry, I misread your comment - yeah we can say try again on error! And then we won't have to mention anything about a stripe terminal.
ctrudeau-stripe
previously approved these changes
Jun 9, 2021
| @@ -61,7 +61,7 @@ export class StripeTerminal { | |||
| if (this.terminals.length > 0) { | |||
| const terminal = await this.createNewSplitTerminal(); | |||
| if (!terminal) { | |||
| throw new Error('Failed to split Stripe terminal'); | |||
| throw new Error('Failed to create a terminal for this Stripe command. Please try again.'); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #266
See the linked issue for an explanation.