Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in split terminal when you "Forward events ..." more than once #266

Closed
vcheung-stripe opened this issue Jun 8, 2021 · 0 comments · Fixed by #267
Closed

Bug in split terminal when you "Forward events ..." more than once #266

vcheung-stripe opened this issue Jun 8, 2021 · 0 comments · Fixed by #267
Assignees
@vcheung-stripe
Milestone
GA

Comments

@vcheung-stripe
Copy link
Collaborator

When you click "Forward events ..." the first time, a terminal is created that runs stripe listen. When you click it again, a new terminal is split from that one. There is a bug where the new split terminal isn't sent the stripe listen command.

As there's no official vscode API for splitting a terminal, we have been relying on this hack: microsoft/vscode#45407 (comment)

Something must have changed in vscode since we implemented that. We should fix it.

We should also move an official vscode API for splitting terminals if that lands.
@vcheung-stripe vcheung-stripe added this to the GA milestone Jun 8, 2021
@vcheung-stripe vcheung-stripe self-assigned this Jun 8, 2021
@vcheung-stripe vcheung-stripe mentioned this issue Jun 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vcheung-stripe vcheung-stripe

Labels
None yet
Projects
None yet
Milestone
GA
Development

Successfully merging a pull request may close this issue.

Fix split terminal bug vcheung-stripe/vscode-stripe
1 participant
@vcheung-stripe