Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): Remove webrtcNewConnectionTimeout config option #2776

Merged
merged 2 commits into from
Oct 2, 2024
Merged

chore(sdk): Remove webrtcNewConnectionTimeout config option #2776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3054f1d
Config
teogeb Oct 1, 2024
88fb897
schema
teogeb Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions packages/sdk/src/Config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,6 @@ export interface ControlLayerConfig {
*/
webrtcAllowPrivateAddresses?: boolean

/**
* Defines WebRTC connection establishment timeout in milliseconds.
*
* When attempting to form a new connection, if not established within
* this timeout, the attempt is considered as failed and further
* waiting for it will cease.
*/
webrtcNewConnectionTimeout?: number

/**
* Sets the low-water mark used by send buffers of WebRTC connections.
*/
Expand Down
4 changes: 0 additions & 4 deletions packages/sdk/src/config.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,6 @@
"type": "boolean",
"default": false
},
"webNewrtcConnectionTimeout": {
"type": "number",
"default": 15000
},
"webrtcDatachannelBufferThresholdLow": {
"type": "number",
"default": 32768
Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/src/generated/validateConfig.js
View file
Open in desktop

Large diffs are not rendered by default.

Loading