Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): Remove webrtcNewConnectionTimeout config option #2776

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

teogeb
Copy link
Contributor

@teogeb teogeb commented Oct 1, 2024

Removed obsole webrtcNewConnectionTimeout config option. It is obsolete, as the corresponding DHT config option was removed (see #2559).

There was a mismatch between Config and config.schema.json: in the schema the property had a deprecated name of newWebrtcConnectionTimeout. The option was renamed in commit 6c8803f. The mismatch means that it has not been possible to use renamed config option in the client as it would have failed the schema validation.

@github-actions github-actions bot added the sdk label Oct 1, 2024
@teogeb teogeb requested a review from juslesan October 1, 2024 20:24
@teogeb teogeb merged commit 8c32ba2 into main Oct 2, 2024
24 checks passed
@teogeb teogeb deleted the rm-sdk-config-webrtcNewConnectionTimeout branch October 2, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants