Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should think carefully about whether create snapshot should be a volume or a pool method. #2

Closed
mulkieran opened this issue Aug 29, 2016 · 1 comment
Closed

Should think carefully about whether create snapshot should be a volume or a pool method. #2

mulkieran opened this issue Aug 29, 2016 · 1 comment
Milestone
Version 0.5

Comments

@mulkieran
Copy link
Member

It may not really matter very much to the underlying implementation. But making a snapshot will definitely affect the pool, in at least as many ways as making a volume.
@mulkieran mulkieran mentioned this issue Aug 30, 2016
Closed
@agrover agrover added this to the Version 0.5 milestone Oct 5, 2016
@mulkieran
Copy link
Member Author

mulkieran commented Dec 2, 2016 •
edited
Loading

Closed by PR #158 where it was decided to go with invoking on the filesystem object path but implementing it internally as a method on a pool

mulkieran pushed a commit that referenced this issue Oct 24, 2021
@mergify
Merge pull request #358 from agrover/add-set-lowat2
0530e8d 
Add ThinPoolDev::set_low_water_mark() #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.5
Development

No branches or pull requests
2 participants
@agrover @mulkieran