Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe DestroySnapshot should not exist. #4

Closed
mulkieran opened this issue Aug 30, 2016 · 3 comments
Closed

Maybe DestroySnapshot should not exist. #4

mulkieran opened this issue Aug 30, 2016 · 3 comments

Comments

@mulkieran
Copy link
Member

Once the snapshot is created, it is a volume like any other. It should be destroyed using the method for removing any volume, DestroyVolumes.
@mulkieran
Copy link
Member Author

This consideration makes it seem more likely that CreateSnapshot should be a pool method, see #2.

@mulkieran
Copy link
Member Author

Request for removing DestroySnapshot: #3.

@agrover agrover added the ready label Aug 30, 2016
@mulkieran
Copy link
Member Author

Merged.

mulkieran referenced this issue in mulkieran/stratisd May 18, 2017
Flesh out dmtest some more
1631d7f 
It looks like our output parsing is working ok, since list_devices and
list_versions both work, but how we're formatting the input buffer is
still wrong because we're failing to set name correctly for table_status,
see #4.

Signed-off-by: Andy Grover <agrover@redhat.com>
mulkieran referenced this issue in mulkieran/stratisd May 18, 2017
Fix table_status's use of targ.next
db10c92 
We were getting panics because targ.next may be nonzero for the last
target entry. target_count is what to go by. Don't use targ.next to get
the next slice in the last loop iteration.

Resolves #4

Signed-off-by: Andy Grover <agrover@redhat.com>
mulkieran referenced this issue in mulkieran/stratisd Nov 8, 2017
@mulkieran
Merge pull request #4 from mulkieran/master-kwargs
8c8b99d 
Master kwargs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agrover @mulkieran