Release: Prerelease beta 8.5.0-beta.10 #30252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y checkbox if a11ytest tag is set on at least one story
… setup and preview files
…ging for a11y addon setup
…g addon migration
…nfiguration handling
… in the preview file
Addon Test: Fix generated path to `vitest.setup.js`
…anel Addon-docs: Make new code panel opt in
A11y Addon: Adjust default behaviour when using with experimental-addon-test
There was a problem hiding this comment.
24 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+14
to
+16
| await $({ | ||
| stdio: 'inherit', | ||
| })`storybook automigrate addonA11yAddonTest ${options.yes ? '--yes' : ''}`; |
There was a problem hiding this comment.
style: stdio: 'inherit' is redundant here since it's already set in the top-level execa config
Comment on lines
+316
to
+317
| lines[tagsLineIndex] = lines[tagsLineIndex].replace("['a11y-test']", "[/*'a11y-test'*/]"); | ||
| lines[tagsLineIndex] = lines[tagsLineIndex].replace('["a11y-test"]', '[/*"a11y-test"*/]'); |
There was a problem hiding this comment.
style: These string replacements are brittle and could break if the input format changes. Consider using AST manipulation instead.
Comment on lines
+33
to
+34
| // Replace your-renderer with the renderer you are using (e.g., react, vue3) | ||
| import { Meta } from '@storybook/your-renderer'; |
There was a problem hiding this comment.
style: The comment should specify that this is for React/Common frameworks rather than using 'your-renderer'
Comment on lines
+124
to
128
| // 👇 Re-include this component's stories in a11y testing by removing the `!ally-test` tag | ||
| tags: [ | ||
| // '!ally-test' | ||
| ], | ||
| }); |
There was a problem hiding this comment.
style: Indentation is inconsistent with the rest of the file - should be aligned with the opening brace
Build: Upgrade scripts dependencies
92d4941 to
d112cb7
Compare
…-document-body-per-default Addon A11y: Change default element selector
d112cb7 to
5e48eb7
Compare
5e48eb7 to
4911535
Compare
|
View your CI Pipeline Execution ↗ for commit 4911535.
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 59 | 59 | 0 |
| Self size | 410 KB | 228 KB | 🎉 -183 KB 🎉 |
| Dependency size | 13.46 MB | 13.46 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-essentials
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 36 | 36 | 0 |
| Self size | 17 KB | 12 KB | 🎉 -4 KB 🎉 |
| Dependency size | 13.83 MB | 13.83 MB | 🎉 -160 B 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-mdx-gfm
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 69 | 69 | 0 |
| Self size | 4 KB | 3 KB | 🎉 -1 KB 🎉 |
| Dependency size | 2.41 MB | 2.41 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/experimental-addon-test
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 60 | 60 | 0 |
| Self size | 974 KB | 762 KB | 🎉 -212 KB 🎉 |
| Dependency size | 14.15 MB | 14.15 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.5.0-beta.9to8.5.0-beta.10.Once this pull request is merged, it will trigger a new release of version
8.5.0-beta.10.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:vitest.setup.js#30233If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.0-beta.10
vitest.setup.js- #30233, thanks @JReinhold!