Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Upgrade scripts dependencies #30182

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Build: Upgrade scripts dependencies #30182

merged 2 commits into from
Jan 13, 2025

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jan 3, 2025

What I did

  • upgrade script dependencies, removing the warning from chromatic that we use an out-dated version

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.8 MB 77.8 MB 0 B 2.33 0%
initSize 131 MB 131 MB 0 B 2.34 0%
diffSize 53 MB 53 MB 0 B 0.79 0%
buildSize 7.19 MB 7.19 MB 0 B 0.65 0%
buildSbAddonsSize 1.85 MB 1.85 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.87 MB 1.87 MB 0 B -0.42 0%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.91 MB 3.91 MB 0 B -0.42 0%
buildPreviewSize 3.28 MB 3.28 MB 0 B 0.65 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 23.8s 13.2s -10s -587ms -0.4 -79.7%
generateTime 20.7s 26.9s 6.2s 4.96 🔺23%
initTime 13.2s 18.6s 5.3s 4.22 🔺29%
buildTime 9.4s 9.8s 440ms 0.36 4.5%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.1s 4.4s -697ms -1.43 🔰-15.7%
devManagerResponsive 3.6s 3.3s -240ms -1.18 -7.1%
devManagerHeaderVisible 687ms 526ms -161ms -1.59 🔰-30.6%
devManagerIndexVisible 721ms 552ms -169ms -1.72 🔰-30.6%
devStoryVisibleUncached 1.5s 1.7s 235ms -0.32 13.1%
devStoryVisible 722ms 553ms -169ms -1.76 🔰-30.6%
devAutodocsVisible 566ms 462ms -104ms -1.22 -22.5%
devMDXVisible 627ms 450ms -177ms -1.67 🔰-39.3%
buildManagerHeaderVisible 610ms 531ms -79ms -0.87 -14.9%
buildManagerIndexVisible 622ms 612ms -10ms -0.9 -1.6%
buildStoryVisible 591ms 514ms -77ms -0.96 -15%
buildAutodocsVisible 502ms 412ms -90ms -1.27 🔰-21.8%
buildMDXVisible 526ms 428ms -98ms -0.81 -22.9%

Greptile Summary

Updates script dependencies in Storybook, primarily upgrading the chromatic package from 11.5.5 to 11.20.2 to address outdated version warnings.

  • Upgrades chromatic from 11.5.5 to 11.20.2 in /scripts/package.json
  • Updates Node.js engine requirement to >=22.0.0
  • Specifies yarn package manager version to 4.4.0
  • Maintains all existing functionality while modernizing dependencies
  • No breaking changes or migration steps required

@ndelangen ndelangen changed the title Buikd: Upgrade scripts dependencies Build: Upgrade scripts dependencies Jan 3, 2025
@ndelangen ndelangen self-assigned this Jan 3, 2025
@ndelangen ndelangen added build Internal-facing build tooling & test updates ci:normal labels Jan 3, 2025
Copy link

nx-cloud bot commented Jan 3, 2025

View your CI Pipeline Execution ↗ for commit 1045b35.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 9s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-13 08:26:17 UTC

@ndelangen ndelangen requested a review from JReinhold January 3, 2025 13:02
@ndelangen ndelangen marked this pull request as ready for review January 3, 2025 13:02
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@ndelangen ndelangen merged commit 4224713 into next Jan 13, 2025
56 of 60 checks passed
@ndelangen ndelangen deleted the norbert/upgrades-2025-1 branch January 13, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants