Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fixes found during 8.5 QA, 2 #30176

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Docs: Fixes found during 8.5 QA, 2 #30176

merged 1 commit into from
Jan 2, 2025

Conversation

kylegach
Copy link
Contributor

@kylegach kylegach commented Jan 2, 2025

What I did

Fix mistakes in #30103

Checklist for Contributors

Testing

N/A — Only addressing mistakes from a prior docs-only PR

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

Greptile Summary

Updates documentation for Webpack to Vite migration and test configuration in Storybook 8.5, improving clarity and accuracy of setup instructions.

  • Fixed variable naming from storybookBaseConfig to config in docs/_snippets/webpack-final-to-vite-final.md Webpack examples
  • Added graphql() plugin import examples for Vite configuration
  • Added configDir option examples in test configuration files
  • Moved coverage exclusion config under Setup section and added **/.storybook/** pattern

💡 (4/5) You can add custom instructions or style guidelines for the bot here!

@kylegach kylegach added documentation ci:docs Run the CI jobs for documentation checks only. labels Jan 2, 2025
@kylegach kylegach self-assigned this Jan 2, 2025
@kylegach kylegach mentioned this pull request Jan 2, 2025
4 tasks
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Jan 2, 2025

View your CI Pipeline Execution ↗ for commit 0556bd2.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 38s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-02 17:21:59 UTC

@kylegach kylegach merged commit fbf01bd into next Jan 2, 2025
7 of 8 checks passed
@kylegach kylegach deleted the 8-5-docs-fixes-2 branch January 2, 2025 17:36
@github-actions github-actions bot mentioned this pull request Jan 2, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant