Docs: Fixes found during 8.5 QA #30103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `configDir` option to example configs
- Move coverage exclusion config under Set up heading
- Add `**/.storybook/**`
There was a problem hiding this comment.
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit 50a61c5.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
LGTM
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
valentinpalkovic
approved these changes
Dec 30, 2024
13 tasks
yannbf
reviewed
Dec 30, 2024
| framework: '@storybook/your-framework', | ||
| stories: ['../src/**/*.mdx', '../stories/**/*.stories.@(js|jsx|mjs|ts|tsx)'], | ||
| async webpackFinal(config) { | ||
| storybookBaseConfig.module?.rules?.push({ |
There was a problem hiding this comment.
@kylegach I assume you wanted to call this config instead?
yannbf
reviewed
Dec 30, 2024
| async viteFinal(config) { | ||
| return { | ||
| ...config, | ||
| plugins: [...(config.plugins ?? []), graphql()], |
There was a problem hiding this comment.
@kylegach did you mean to add the import for the graphql plugin? or does it just represent the concept of a plugin?
kylegach
added a commit
that referenced
this pull request
Jan 2, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
configDiroption to example configs**/.storybook/**viteFinalguidanceChecklist for Contributors
Testing
Manual testing
Sync this branch with locally running docs site
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.Greptile Summary
Updates documentation for Vitest plugin and test coverage configuration in Storybook 8.5, improving clarity and organization of setup instructions.
configDiroption indocs/_snippets/vitest-plugin-vitest-config.mdandvitest-plugin-vitest-workspace.mdfor React, Vue, and Svelte frameworksdocs/writing-tests/test-coverage.mdx**/.storybook/**to coverage exclusion patternsdocs/writing-tests/test-addon.mdxto indicate additional configuration options instorybookTestplugin💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!