Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Add global box-sizing setting. Fixes #10207 #11055

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

matheo
Copy link
Member

@matheo matheo commented Jun 5, 2020

Issue: #10207

@shilman any other way to set this global style? or this is fine?

@matheo matheo requested a review from shilman June 5, 2020 14:54
@shilman
Copy link
Member

shilman commented Jun 5, 2020

@matheo i think this is a @ndelangen question :)

@matheo matheo requested a review from ndelangen June 5, 2020 23:58
@ndelangen
Copy link
Member

I think this might be a better place for it.

...resetStyles,
body: {
...resetStyles.body,
color: color.defaultText,
background: background.app,
overflow: 'hidden',
},
hr: {
...resetStyles.hr,
borderTop: `1px solid ${color.border}`,
},
};
}

I foresee a problem with this though:

We render storybook UI components in 2 places: In the manager and in addon-docs.

This change will be problematic for the latter.

If our UI components start expecting to be rendered with these global styles, (which will potentially not be the case in addon-docs) this could cause problems for us.

Can we fix #10207 in another more specific method?

@matheo
Copy link
Member Author

matheo commented Jun 7, 2020

@ndelangen a global reset seems to be better. See #11071

@shilman
Copy link
Member

shilman commented Jun 15, 2020

@matheo @ndelangen any chance we can push this forward in the next few days?

@ndelangen ndelangen merged commit 66e6413 into storybookjs:next Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants